All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Prarit Bhargava <prarit@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	John Stultz <john.stultz@linaro.org>,
	Xunlei Pang <pang.xunlei@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Baolin Wang <baolin.wang@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Tejun Heo <tj@kernel.org>,
	Peter Hurley <peter@hurleysoftware.com>,
	Vasily Averin <vvs@virtuozzo.com>, Joe Perches <joe@perches.com>
Subject: Re: [PATCH 1/2] lib, switch CONFIG_PRINTK_TIME to int
Date: Mon, 25 Apr 2016 17:59:38 +0200	[thread overview]
Message-ID: <20160425155938.GC19702@pathway.suse.cz> (raw)
In-Reply-To: <1461326589-27722-2-git-send-email-prarit@redhat.com>

On Fri 2016-04-22 08:03:08, Prarit Bhargava wrote:
> CONFIG_PRINTK_TIME is a bool and in order to add timestamp options for
> the monotonic and real time clock it must be expanded to an int.
> 
> diff --git a/arch/x86/configs/x86_64_defconfig b/arch/x86/configs/x86_64_defconfig
> index 4f404a6..0250dbd 100644
> --- a/arch/x86/configs/x86_64_defconfig
> +++ b/arch/x86/configs/x86_64_defconfig
> @@ -284,7 +284,7 @@ CONFIG_NLS_CODEPAGE_437=y
>  CONFIG_NLS_ASCII=y
>  CONFIG_NLS_ISO8859_1=y
>  CONFIG_NLS_UTF8=y
> -CONFIG_PRINTK_TIME=y
> +CONFIG_PRINTK_TIME=1
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set
>  CONFIG_MAGIC_SYSRQ=y
>  # CONFIG_UNUSED_SYMBOLS is not set
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 1e9a607..774aa38 100644
[...]
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1,7 +1,9 @@
>  menu "printk and dmesg options"
>  
>  config PRINTK_TIME
> -	bool "Show timing information on printks"
> +	int "Show timing information on printks (0-1)"
> +	range 0 1
> +	default "0"

I get "0" as the default when running "make" with this patch:

$>> make oldconfig
scripts/kconfig/conf  --oldconfig Kconfig
.config:3463:warning: symbol value 'y' invalid for PRINTK_TIME
*
* Restart config...
*
*
* printk and dmesg options
*
Show timing information on printks (0-3) (PRINTK_TIME) [0] (NEW) 
                                                       ^^^

And it really writes 0 into .config:

$>> grep PRINTK_TIME .config
CONFIG_PRINTK_TIME=0

It seems that arch/x86/configs/x86_64_defconfig is used only when
you call "make defconfig"

Hmm, this might be surprising and annoying for many people. I would
suggest to make "1" as the default value and remove the default from
all that defconfigs. It is default on almost all systems and it is
why people would expect.

Best Regards,
Petr

  reply	other threads:[~2016-04-25 15:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-22 12:03 [PATCH 0/2 v7]: printk, Add monotonic and real printk timestamps Prarit Bhargava
2016-04-22 12:03 ` [PATCH 1/2] lib, switch CONFIG_PRINTK_TIME to int Prarit Bhargava
2016-04-25 15:59   ` Petr Mladek [this message]
2016-04-22 12:03 ` [PATCH 2/2] printk, allow different timestamps for printk.time Prarit Bhargava
2016-04-22 19:47   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160425155938.GC19702@pathway.suse.cz \
    --to=pmladek@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=baolin.wang@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pang.xunlei@linaro.org \
    --cc=peter@hurleysoftware.com \
    --cc=prarit@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=vvs@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.