From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933120AbcDYQSv (ORCPT ); Mon, 25 Apr 2016 12:18:51 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:37258 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932994AbcDYQSs (ORCPT ); Mon, 25 Apr 2016 12:18:48 -0400 Date: Mon, 25 Apr 2016 17:18:48 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Tony Lindgren Subject: Re: [PATCH 2/2] mfd: twl6040: Check clk_prepare_enable() return value in twl6040_power() Message-ID: <20160425161848.GL2713@dell> References: <1461165398-12289-1-git-send-email-javier@osg.samsung.com> <1461165398-12289-2-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1461165398-12289-2-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 Apr 2016, Javier Martinez Canillas wrote: > The clk_prepare_enable() function can fail so check the return > value and propagate the error in case of a failure. > > Signed-off-by: Javier Martinez Canillas > > --- > > drivers/mfd/twl6040.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/twl6040.c b/drivers/mfd/twl6040.c > index 4de92c16dfb8..852d5874aabb 100644 > --- a/drivers/mfd/twl6040.c > +++ b/drivers/mfd/twl6040.c > @@ -291,7 +291,11 @@ int twl6040_power(struct twl6040 *twl6040, int on) > if (twl6040->power_count++) > goto out; > > - clk_prepare_enable(twl6040->clk32k); > + ret = clk_prepare_enable(twl6040->clk32k); > + if (ret) { > + twl6040->power_count = 0; > + goto out; > + } > > /* Allow writes to the chip */ > regcache_cache_only(twl6040->regmap, false); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog