From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from vms173023pub.verizon.net (vms173023pub.verizon.net [206.46.173.23]) by mail.openembedded.org (Postfix) with ESMTP id 188A073174 for ; Mon, 25 Apr 2016 16:26:36 +0000 (UTC) Received: from vz-proxy-l007.mx.aol.com ([64.236.82.157]) by vms173023.mailsrvcs.net (Oracle Communications Messaging Server 7.0.5.32.0 64bit (built Jul 16 2014)) with ESMTPA id <0O6700KQL6ZVS280@vms173023.mailsrvcs.net> for openembedded-core@lists.openembedded.org; Mon, 25 Apr 2016 11:26:25 -0500 (CDT) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.1 cv=EdU1O6SC c=1 sm=1 tr=0 a=EDyElNE8DnJcdewKkuvZJw==:117 a=kj9zAlcOel0A:10 a=kziv93cY1bsA:10 a=sozttTNsAAAA:8 a=Q4-j1AaZAAAA:8 a=ftazcBhzXC-Bvip6HBsA:9 a=0bXxn9q0MV6snEgNplNhOjQmxlI=:19 a=CjuIK1q_8ugA:10 Received: by 100.15.86.14 with SMTP id 059bf11a; Mon, 25 Apr 2016 16:26:24 GMT Received: by gandalf.denix.org (Postfix, from userid 1000) id 1C784161FC8; Mon, 25 Apr 2016 12:26:19 -0400 (EDT) Date: Mon, 25 Apr 2016 12:26:19 -0400 From: Denys Dmytriyenko To: openembedded-core@lists.openembedded.org Message-id: <20160425162619.GU16135@denix.org> References: <1461264262-31937-1-git-send-email-denis@denix.org> MIME-version: 1.0 In-reply-to: <1461264262-31937-1-git-send-email-denis@denix.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: Denys Dmytriyenko Subject: Re: [PATCH] sdk.py: preserve packaging data when SDKIMAGE_FEATURES has "package-management" X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Apr 2016 16:26:37 -0000 Content-type: text/plain; charset=us-ascii Content-disposition: inline Any comments? On Thu, Apr 21, 2016 at 02:44:22PM -0400, Denys Dmytriyenko wrote: > From: Denys Dmytriyenko > > This is not enabled by default, as there are still limitations and possible > issues with opkg (and rpm?) packaging data containing broken symlinks for > local indexes: > > http://cgit.openembedded.org/openembedded-core/commit/?id=c8e0ec2da9ad4ce1c103966906a85f68c15400dd > > There are other use cases for the packaging data to be available in SDK, > since it provides comprehensive info about SDK's contents and in the case of > opkg and dpkg is all text-based and can be easily parsed by simple scripts. > > Introduce new "package-management" flag for SDKIMAGE_FEATURES list (similar > to the one already used for IMAGE_FEATURES) that controls presence of the > packaging data in resulting SDK, while unifying this behavior across the > board for supported pkg managers - rpm, opkg, dpkg. > > Signed-off-by: Denys Dmytriyenko > --- > meta/lib/oe/sdk.py | 18 ++++++++++++++---- > 1 file changed, 14 insertions(+), 4 deletions(-) > > diff --git a/meta/lib/oe/sdk.py b/meta/lib/oe/sdk.py > index f15fbdb..f1bbef6 100644 > --- a/meta/lib/oe/sdk.py > +++ b/meta/lib/oe/sdk.py > @@ -155,14 +155,16 @@ class RpmSdk(Sdk): > > execute_pre_post_process(self.d, self.d.getVar("POPULATE_SDK_POST_TARGET_COMMAND", True)) > > - self.target_pm.remove_packaging_data() > + if not bb.utils.contains("SDKIMAGE_FEATURES", "package-management", True, False, self.d): > + self.target_pm.remove_packaging_data() > > bb.note("Installing NATIVESDK packages") > self._populate_sysroot(self.host_pm, self.host_manifest) > > execute_pre_post_process(self.d, self.d.getVar("POPULATE_SDK_POST_HOST_COMMAND", True)) > > - self.host_pm.remove_packaging_data() > + if not bb.utils.contains("SDKIMAGE_FEATURES", "package-management", True, False, self.d): > + self.host_pm.remove_packaging_data() > > # Move host RPM library data > native_rpm_state_dir = os.path.join(self.sdk_output, > @@ -232,14 +234,16 @@ class OpkgSdk(Sdk): > > execute_pre_post_process(self.d, self.d.getVar("POPULATE_SDK_POST_TARGET_COMMAND", True)) > > - self.target_pm.remove_packaging_data() > + if not bb.utils.contains("SDKIMAGE_FEATURES", "package-management", True, False, self.d): > + self.target_pm.remove_packaging_data() > > bb.note("Installing NATIVESDK packages") > self._populate_sysroot(self.host_pm, self.host_manifest) > > execute_pre_post_process(self.d, self.d.getVar("POPULATE_SDK_POST_HOST_COMMAND", True)) > > - self.host_pm.remove_packaging_data() > + if not bb.utils.contains("SDKIMAGE_FEATURES", "package-management", True, False, self.d): > + self.host_pm.remove_packaging_data() > > target_sysconfdir = os.path.join(self.sdk_target_sysroot, self.sysconfdir) > host_sysconfdir = os.path.join(self.sdk_host_sysroot, self.sysconfdir) > @@ -314,6 +318,9 @@ class DpkgSdk(Sdk): > > self._copy_apt_dir_to(os.path.join(self.sdk_target_sysroot, "etc", "apt")) > > + if not bb.utils.contains("SDKIMAGE_FEATURES", "package-management", True, False, self.d): > + self.target_pm.remove_packaging_data() > + > bb.note("Installing NATIVESDK packages") > self._populate_sysroot(self.host_pm, self.host_manifest) > > @@ -322,6 +329,9 @@ class DpkgSdk(Sdk): > self._copy_apt_dir_to(os.path.join(self.sdk_output, self.sdk_native_path, > "etc", "apt")) > > + if not bb.utils.contains("SDKIMAGE_FEATURES", "package-management", True, False, self.d): > + self.host_pm.remove_packaging_data() > + > native_dpkg_state_dir = os.path.join(self.sdk_output, self.sdk_native_path, > "var", "lib", "dpkg") > self.mkdirhier(native_dpkg_state_dir) > -- > 2.2.0 > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core