From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933301AbcDYS4j (ORCPT ); Mon, 25 Apr 2016 14:56:39 -0400 Received: from mga09.intel.com ([134.134.136.24]:60212 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933240AbcDYS4i (ORCPT ); Mon, 25 Apr 2016 14:56:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,533,1455004800"; d="scan'208";a="792119467" Date: Mon, 25 Apr 2016 21:56:33 +0300 From: Jarkko Sakkinen To: Greg KH Cc: "open list:STAGING SUBSYSTEM" , open list Subject: Re: [PATCH 6/6] intel_sgx: TODO file for the staging area Message-ID: <20160425185633.GB15368@intel.com> References: <1461605698-12385-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1461605698-12385-7-git-send-email-jarkko.sakkinen@linux.intel.com> <20160425175426.GB16786@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160425175426.GB16786@kroah.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 25, 2016 at 10:54:26AM -0700, Greg KH wrote: > On Mon, Apr 25, 2016 at 08:34:13PM +0300, Jarkko Sakkinen wrote: > > Signed-off-by: Jarkko Sakkinen > > --- > > drivers/staging/intel_sgx/TODO | 25 +++++++++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > create mode 100644 drivers/staging/intel_sgx/TODO > > > > diff --git a/drivers/staging/intel_sgx/TODO b/drivers/staging/intel_sgx/TODO > > new file mode 100644 > > index 0000000..05f68c2 > > --- /dev/null > > +++ b/drivers/staging/intel_sgx/TODO > > @@ -0,0 +1,25 @@ > > +Documentation > > +============= > > + > > +* Improve Documents/x86/intel-sgx.txt based on the feedback and > > + questions that pop up. > > + > > +Internals > > +========= > > + > > +* Move structures needed by the allocator to arch/x86/include/asm/sgx.h > > +* Move EPC page allocation and eviction code to arch/x86/mm as they > > + will shared with virtualization code. > > +* Move enclave management functions to arch/x86/mm as they will be > > + shared with virtualization code. > > +* Use reserve_memtype() in order to add EPC to the PAT memtype list > > + with WB caching. > > +* Implement proper recovery code for the pager for cases when > > + ETRACK/EBLOCK/EWB fails instead of BUG_ON(). Probably the sanest > > + way to recover is to clear TCS PTEs, kick threads out of enclave > > + and remove EPC pages. > > +* Implement ACPI hot-lug for SGX. > > What is keeping you from doing all of this work this week, making this > todo list empty? I could. I took the internal driver code and just enumerated the tasks that I saw that need to be done before it's ready from my point of view. I just wanted intial feedback before starting to work through these so that I know my aim is right. > thanks, > > greg k-h /Jarkko