From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752153AbcDZFvn (ORCPT ); Tue, 26 Apr 2016 01:51:43 -0400 Received: from mail-bn1bon0079.outbound.protection.outlook.com ([157.56.111.79]:22144 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751027AbcDZFvl (ORCPT ); Tue, 26 Apr 2016 01:51:41 -0400 Authentication-Results: the-dreams.de; dkim=none (message not signed) header.d=none;the-dreams.de; dmarc=none action=none header.from=caviumnetworks.com; Date: Tue, 26 Apr 2016 07:51:22 +0200 From: Jan Glauber To: Wolfram Sang CC: , , David Daney Subject: Re: [PATCH v7 05/15] i2c: octeon: Enable High-Level Controller Message-ID: <20160426055122.GA5758@hardcore> References: <1461594824-7215-1-git-send-email-jglauber@cavium.com> <1461594824-7215-6-git-send-email-jglauber@cavium.com> <20160425214429.GE1550@katana> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160425214429.GE1550@katana> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [46.223.168.231] X-ClientProxiedBy: DB5PR01CA0033.eurprd01.prod.exchangelabs.com (10.162.149.171) To SN2PR07MB2589.namprd07.prod.outlook.com (10.167.15.19) X-MS-Office365-Filtering-Correlation-Id: 12fa566a-e496-4614-2df8-08d36d96d427 X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2589;2:9Y+sZ8mHY2eVAmryUta9d1GBZggQ13vF61HxkbkFXbMg3mZkKl+G+y4cczqM0Yvw+Qt/idzZjVbLWGIq1GLmruSXXDSE5gRR0zockkt91IsycmgUkDqYWLhPKIoFShF13j6znByUflUbXWQF1PsLguH0QmP/ziXuhW2c8GYcKGv5VGeIr7QobEJr1eebAJ1k;3:R5Or1xNlOqkQZIfa94KYTXkfhjeehW/ZYkbOQa1ikl5Wa4TjejaysSblAgjwmVxTHVRpnOdQXv2Sn17xn/wv2iFbBSsIJxgJXmLHS/8lIVAAEwWA0DyoWHLieMDh6A9w;25:IUEBsCUqtKKYMNwMB/pl/psS07yQ+hQ2tKZWOrZsSJ/33dcuI/S2sEt7aV89Iy4Z6vkdCVLnQjYh3o2l0HjzwWWai7EA//LoFh35Gd66Vm0PHOGlZ1QZVGccw4M4fDWBFRVgLOW7S3Tq1eCh9s+8cTUHpzcpD+qiRQR8g0ZPgxO6exGkb2J1owSs/KWtvrP5bM6Fpb5giUJGHmh76sWiB+PlmEbyOIPBRAwQ6MdDa9xJMmwF7qraSAdh8Fd8MhA97tjshnkCvfct3OEtOxiZ3Ygd+Tp0dwHz2YSHD/ki5f2zVZSJQn/rQxFrCbpCbnudVUwoEjflvULfmKO/QDsqYg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN2PR07MB2589; X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2589;20:eLNhAqE5udhbaZ1QNHemNbK+Kww8N7l4Fud2tWPmVZbXuXzAAb3LKYQ798udep8Q/iS+aDBVNHdjDSM+s2wSutHFuBy9KBdjPA/s/zTr4/N6I8y2mWXxRIN0gLABSeqe6iq+frXV/kdk93Bp2uXqtTJ5o4IzBQ5saBr2NNVeFurGmsfsiX6XUJiH89EYicceV9sU+Kv4oKglcynvnd7H/m1o1rltbSCoTrl3L6orPy6BxxNMQns2bIYNSfBagcEcIMycpUlsuzQuoOBr/LRQc+YbGZZ87SP6+3UVWONya/MNQQbzv6QKj/1xRfbPE38RIV5s4zpzHHXtQgFg4Ekc67tUecMCKJgbLONTrDLGXL+6PAVfH/YDQNqHt5J31kAw8fU6xY8cP041cNSaEHr40s1xDZtjFKU0xeKFo2rhsWtXiOlVDYWDZ0HjYzpzCWHPiHdXrKCggOKr2b+rvfEEyfVi2Mwv/yn7ZEpA6HZb3gkO9CwF7pEnpjtV4wJUr2omzBkj1qMYr1BfSO+Ybx6DwZHI5J0fgp4sC3g5S3XTD+RzeL+614Pma3eFwSEzCVS1GYw1sqFPicZKem+z/VdqtXBj0QG1AYUSbuPO5xUwvQs= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(9101521072)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:SN2PR07MB2589;BCL:0;PCL:0;RULEID:;SRVR:SN2PR07MB2589; X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2589;4:klW6VIk5EZTIK7Mfp/SgEsMVKPa+tWtTZYoR8M2al/PMfC2aMHv3fNHojcOfmqQ9F3n6ByRmm5Q2XL6cAu5rjtC26lPj4euLXfJdQZGpQtxf+MniShG8uJ6lgN7IYu69Fd9ok4YGPgDTDKfdFa6YXItLDT+i/oWPtcAjS7j4w7lGF4D4aLIHN2UK3nu5NYUod5CJvBk25nVJHtk6zWrmKECX0h4dPwhL7OebArI4e3UQEP+MWCpcUw82Wq/G/R8T59Zs8asix4LUeV9hlni1rVde+NjE36lQhXhmdUKnqyVz/FddMF+DUxxntjc08/a6UCLPWLlUFnsUY2ttbT5D0a50W9fVIlIlUHU3xRqnqmUCisIZWIlXKFbX+m7NfX3MLI/6PDGFyDWe2Usitm/KOQ== X-Forefront-PRVS: 0924C6A0D5 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(24434003)(24454002)(46406003)(9686002)(5008740100001)(42186005)(33656002)(107886002)(110136002)(189998001)(4001350100001)(33716001)(19580405001)(586003)(2906002)(23726003)(19580395003)(6116002)(66066001)(77096005)(2950100001)(3846002)(47776003)(1076002)(86362001)(83506001)(1096002)(97756001)(54356999)(81166005)(50986999)(76176999)(4326007)(92566002)(5004730100002)(50466002);DIR:OUT;SFP:1101;SCL:1;SRVR:SN2PR07MB2589;H:hardcore;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN2PR07MB2589;23:BbFmey3z1cvj2oAh6yvP6E9u9TWEYiQTL4QG8L478?= =?us-ascii?Q?WVLItYKcE4bP3Lmih3BVOnRCUAjhG13dF/bR5is4b62QPTr22Px0HhJRAEUB?= =?us-ascii?Q?VMlZ3PiGj0uBfz6PxkIdVwK1OV6SjwT2fzewBqoY7j5lx7yOT07WgsctVk8m?= =?us-ascii?Q?IETqzes6PzSHYWqhYJusx5iuLXrHA8m4vas0sYiAH/HkDVyrno+etgeWZlFx?= =?us-ascii?Q?zgdh6U+QAVClSsTyzZzmDI7JXLDtjEkdCZ/goC00imnD95gv1Bhz9M4Ev5Bq?= =?us-ascii?Q?a0szUmxvfJtF13fkQDLyIX0Z2KCqQ9GnBlMTHPIms7HGovW3lV0UgnQawsIJ?= =?us-ascii?Q?CpLITGPfcWeuJOdLZsy9ixfb6hOA24L1pwmmyyRJEWdlUXa2kAbq4hFJUi24?= =?us-ascii?Q?QXOQ19/vGsZGpMB63VWYE4ELq4wQ8q7fXTQmC29421fhY3atnlzGChaOsLKC?= =?us-ascii?Q?pba4ZfwunfKD6J28KUMp5CJ3Cdo94w8QXlGe9EpgemUvYVb4/RhGT7oeJ7eQ?= =?us-ascii?Q?2LTel3u3wwukxgC4hlnt9DAxWtef/nvve+sKs8+AoRDbHNl4Ve21u+ivEWls?= =?us-ascii?Q?XwepTkpGFUxcXcAQLToLezmrLeSQfHVXxsa7bEgdN6qB/runOEwE6Yfm7Phz?= =?us-ascii?Q?WXzqwZDk7mZlCj8vZxIuo6DtdONWvkxhpPG7WjojpQksdQklgL7qp4b7ldRo?= =?us-ascii?Q?9glxXfHm+3OBYCXq1JkTaI+sXvqD/3x1yA8CBJBKwz18XrMA2UMMC/jZO4i/?= =?us-ascii?Q?r7L2clGQcaSdm1sy1z2ViCwJGgt/4wwCBu6WdADF8g+lSKNKb2qz2+8wwobS?= =?us-ascii?Q?vOgVMj7n6cMlcFK44e9hW5j7tOxoFtNnXxl3eBfcQGbqToxLM/m25QKqAPsx?= =?us-ascii?Q?KU5Gktqgb+N7P4nfVR4C1YgnD8czQl1yQEyZDx+g3Dwv4iy0mLouGLmDtze0?= =?us-ascii?Q?KMWFqaOOmwMmWoDecfTjIiT4HBjX1Z0Bj1mY7VzS1Ueeyx5fGJLTfWf6k6IB?= =?us-ascii?Q?idH7y9wlNkZrOZoUqJ3IPaN?= X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2589;5:hhGA7/IeE2T6i4nOY+Ich0H2UKU8A7cLXuhWJMq4CZrtek3/EM73msWYozrpZE5WQRC98rE4D+w7O3TYdtMhH9nFZg+vVe9RKBSeRagE06T+lNSWjkRhvklo6WqL35nQJzcTutDhpIKdgCp29RH9+gGe1LNId+c1fn4ZtdGvU/XE1a9/FHkRCfewdXwJIqow;24:Hsurmh+TplMQqed1FR7l7RpLDpMaibIMhR7cKPg8Ys1KgOckOAD1lcfhhExc+GUpBA4lTT5OrdY3d2DBInWqDt34AQ4qmGgyPj/ZWoY44dA=;7:TscCEhb5+BfbRzkwMezAUcVsIE99+VNtJlSqdxiqU2qDpDc6yo69umoRu3V96JarFKkY98wzEc8I6+7zVODKSvDB/BZKWWmLn6pjhMRGHYUS5jHKl5gVoC5cDmfIvyvLzJVklGpdELUUFHZday7DsPCcdbx5lIvxq3MvxJcZAy3xiidjmPw6SwEa0atJFKQGbeDbS0DHzlPEVdAs9iZLNJet9mxz6vQI3DuzeFBZQ0s= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2016 05:51:34.4824 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2589 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 25, 2016 at 11:44:29PM +0200, Wolfram Sang wrote: > On Mon, Apr 25, 2016 at 04:33:34PM +0200, Jan Glauber wrote: > > From: David Daney > > > > Use High-Level Controller (HLC) when possible. The HLC can read/write > > up to 8 bytes and is completely optional. The most important difference > > of the HLC is that it only requires one interrupt for a transfer > > (up to 8 bytes) where the low-level read/write requires 2 interrupts > > plus one interrupt per transferred byte. Since the interrupts are costly > > using the HLC improves the performance. Also, the HLC provides improved > > error handling. > > > > Signed-off-by: David Daney > > Signed-off-by: Jan Glauber > > Applied to for-next, thanks! > > I can recommend using --strict with checkpatch. It found some issues: I thought checkpatch is always strict, but seriously, I didn't know that option. Thanks for fixing that! Jan > total: 0 errors, 0 warnings, 18 checks, 427 lines checked > > CHECK: No space is necessary after a cast > #327: FILE: drivers/i2c/busses/i2c-octeon.c:563: > + ext |= (u64) msgs[0].buf[0] << SW_TWSI_IA_SHIFT; > > I fixed all 14 of those. > > CHECK: braces {} should be used on all arms of this statement > #325: FILE: drivers/i2c/busses/i2c-octeon.c:561: > + if (msgs[0].len == 2) { > [...] > + } else > [...] > > and 2 of those. > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Glauber Subject: Re: [PATCH v7 05/15] i2c: octeon: Enable High-Level Controller Date: Tue, 26 Apr 2016 07:51:22 +0200 Message-ID: <20160426055122.GA5758@hardcore> References: <1461594824-7215-1-git-send-email-jglauber@cavium.com> <1461594824-7215-6-git-send-email-jglauber@cavium.com> <20160425214429.GE1550@katana> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from mail-bn1bon0079.outbound.protection.outlook.com ([157.56.111.79]:22144 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751027AbcDZFvl (ORCPT ); Tue, 26 Apr 2016 01:51:41 -0400 Content-Disposition: inline In-Reply-To: <20160425214429.GE1550@katana> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Wolfram Sang Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, David Daney On Mon, Apr 25, 2016 at 11:44:29PM +0200, Wolfram Sang wrote: > On Mon, Apr 25, 2016 at 04:33:34PM +0200, Jan Glauber wrote: > > From: David Daney > > > > Use High-Level Controller (HLC) when possible. The HLC can read/write > > up to 8 bytes and is completely optional. The most important difference > > of the HLC is that it only requires one interrupt for a transfer > > (up to 8 bytes) where the low-level read/write requires 2 interrupts > > plus one interrupt per transferred byte. Since the interrupts are costly > > using the HLC improves the performance. Also, the HLC provides improved > > error handling. > > > > Signed-off-by: David Daney > > Signed-off-by: Jan Glauber > > Applied to for-next, thanks! > > I can recommend using --strict with checkpatch. It found some issues: I thought checkpatch is always strict, but seriously, I didn't know that option. Thanks for fixing that! Jan > total: 0 errors, 0 warnings, 18 checks, 427 lines checked > > CHECK: No space is necessary after a cast > #327: FILE: drivers/i2c/busses/i2c-octeon.c:563: > + ext |= (u64) msgs[0].buf[0] << SW_TWSI_IA_SHIFT; > > I fixed all 14 of those. > > CHECK: braces {} should be used on all arms of this statement > #325: FILE: drivers/i2c/busses/i2c-octeon.c:561: > + if (msgs[0].len == 2) { > [...] > + } else > [...] > > and 2 of those. >