All of lore.kernel.org
 help / color / mirror / Atom feed
From: Raghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com>
To: JBottomley@odin.com, linux-scsi@vger.kernel.org,
	martin.petersen@oracle.com
Cc: aacraid@pmc-sierra.com, gana.sridaran@microsemi.com,
	scott.benesh@microsemi.com, vishal.josemannanal@microsemi.com,
	RaghavaAditya.Renukunta@microsemi.com
Subject: [PATCH 04/10] aacraid: Relinquish CPU during timeout wait
Date: Mon, 25 Apr 2016 23:31:26 -0700	[thread overview]
Message-ID: <20160426063126.28402.85984.stgit@pmcuser-System-Product-Name> (raw)
In-Reply-To: <20160426062414.28402.69178.stgit@pmcuser-System-Product-Name>

aac_fib_send has a special function case for initial commands during
driver initialization using wait < 0(pseudo sync mode). In this case,
the command does not sleep but rather spins checking for timeout.This
loop is calls cpu_relax() in an attempt to allow other processes/threads
to use the CPU, but this function does not relinquish the CPU and so the
command will hog the processor. This was observed in a KDUMP
"crashkernel" and that prevented the "command thread" (which is
responsible for completing the command from being timed out) from
starting because it could not get the CPU.

Fixed by replacing "cpu_relax()" call with "schedule()"
Cc: stable@vger.kernel.org

Signed-off-by: Raghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com>
---
 drivers/scsi/aacraid/commsup.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c
index 511bbc5..725aa78 100644
--- a/drivers/scsi/aacraid/commsup.c
+++ b/drivers/scsi/aacraid/commsup.c
@@ -637,10 +637,10 @@ int aac_fib_send(u16 command, struct fib *fibptr, unsigned long size,
 					}
 					return -EFAULT;
 				}
-				/* We used to udelay() here but that absorbed
-				 * a CPU when a timeout occured. Not very
-				 * useful. */
-				cpu_relax();
+				/*
+				 * Allow other processes / CPUS to use core
+				 */
+				schedule();
 			}
 		} else if (down_interruptible(&fibptr->event_wait)) {
 			/* Do nothing ... satisfy


  parent reply	other threads:[~2016-04-26  6:35 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-26  6:30 [PATCH 00/10] aacraid: Patchset for aacraid driver version 41066 Raghava Aditya Renukunta
2016-04-26  6:30 ` [PATCH 01/10] aacraid: Removed unnecessary checks for NULL Raghava Aditya Renukunta
2016-04-26  6:31 ` [PATCH 02/10] aacraid: Fix incorrectly named MACRO Raghava Aditya Renukunta
2016-04-27  9:14   ` Johannes Thumshirn
2016-04-26  6:31 ` [PATCH 03/10] aacraid: Start adapter after updating number of MSIX vectors Raghava Aditya Renukunta
2016-04-27  9:14   ` Johannes Thumshirn
2016-04-26  6:31 ` Raghava Aditya Renukunta [this message]
2016-04-27  9:31   ` [PATCH 04/10] aacraid: Relinquish CPU during timeout wait Johannes Thumshirn
2016-04-26  6:31 ` [PATCH 05/10] aacraid: Disable MSI mode for series 6, 7, 8 cards Raghava Aditya Renukunta
2016-04-27  9:16   ` Johannes Thumshirn
2016-04-26  6:31 ` [PATCH 06/10] aacraid: Fix for aac_command_thread hang Raghava Aditya Renukunta
2016-04-27  9:32   ` Johannes Thumshirn
2016-04-26  6:32 ` [PATCH 07/10] aacraid: Log firmware AIF messages Raghava Aditya Renukunta
2016-04-27  9:21   ` Johannes Thumshirn
2016-04-26  6:32 ` [PATCH 08/10] aacraid: Remove code to needlessly complete fib Raghava Aditya Renukunta
2016-04-27  9:24   ` Johannes Thumshirn
2016-04-27 16:34     ` Raghava Aditya Renukunta
2016-04-28  7:47       ` Johannes Thumshirn
2016-04-26  6:32 ` [PATCH 09/10] aacraid: Fix for KDUMP driver hang Raghava Aditya Renukunta
2016-04-27  9:29   ` Johannes Thumshirn
2016-04-27 16:49     ` Raghava Aditya Renukunta
2016-04-28  7:49       ` Johannes Thumshirn
2016-04-26  6:32 ` [PATCH 10/10] aacraid: Update driver version Raghava Aditya Renukunta
2016-04-27  9:30   ` Johannes Thumshirn
2016-04-29 23:15 ` [PATCH 00/10] aacraid: Patchset for aacraid driver version 41066 Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160426063126.28402.85984.stgit@pmcuser-System-Product-Name \
    --to=raghavaaditya.renukunta@microsemi.com \
    --cc=JBottomley@odin.com \
    --cc=aacraid@pmc-sierra.com \
    --cc=gana.sridaran@microsemi.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=scott.benesh@microsemi.com \
    --cc=vishal.josemannanal@microsemi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.