From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Gordeev Subject: Re: [PATCH RFC 12/15] Factor out generic architecture code Date: Tue, 26 Apr 2016 10:24:44 +0200 Message-ID: <20160426082443.GA10320@dhcp-27-118.brq.redhat.com> References: <8a0723604a705e6c24f5cc5c062743236d7a4c70.1460190352.git.agordeev@redhat.com> <20160422155412.4cz4plm6omrwemed@hawk.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, Thomas Huth To: Andrew Jones Return-path: Received: from mx1.redhat.com ([209.132.183.28]:53760 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752226AbcDZIYs (ORCPT ); Tue, 26 Apr 2016 04:24:48 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C03AFC049D60 for ; Tue, 26 Apr 2016 08:24:47 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160422155412.4cz4plm6omrwemed@hawk.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Apr 22, 2016 at 05:54:12PM +0200, Andrew Jones wrote: > > -static inline unsigned long virt_to_phys(const void *virt) > > -{ > > - return (unsigned long)virt; > > -} > > - > > -static inline void *phys_to_virt(unsigned long phys) > > -{ > > - return (void *)phys; > > -} > > - > > Uh oh. You've now changed x86's virt_to_phys/phys_to_virt to using > phys_addr_t. The unit tests may not be happy! What might go wrong with phys_addr_t? > thanks, > drew