From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v6 6/8] qede: Add attention support
Date: Tue, 26 Apr 2016 14:25:33 +0100
Message-ID: <20160426132533.GA10896@bricha3-MOBL3>
References: <1461647586-22234-1-git-send-email-rasesh.mody@qlogic.com>
 <1461647586-22234-6-git-send-email-rasesh.mody@qlogic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: thomas.monjalon@6wind.com, dev@dpdk.org, ameen.rahman@qlogic.com,
 Harish Patil <harish.patil@qlogic.com>,
 Sony Chacko <sony.chacko@qlogic.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 42987DE0
 for <dev@dpdk.org>; Tue, 26 Apr 2016 15:25:49 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1461647586-22234-6-git-send-email-rasesh.mody@qlogic.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Apr 25, 2016 at 10:13:04PM -0700, Rasesh Mody wrote:
> Physical link is handled by the management Firmware.
> This patch lays the infrastructure for attention handling in the driver,
> as link change notifications arrive via async attentions, as well as the
> handling of such notifications. It adds async event notification handler
> interfaces to the PMD.
> 
> Signed-off-by: Harish Patil <harish.patil@qlogic.com>
> Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
> Signed-off-by: Sony Chacko <sony.chacko@qlogic.com>
> ---
>  drivers/net/qede/base/ecore_attn_values.h |13287 +++++++++++++++++++++++++++++
>  drivers/net/qede/base/ecore_dev.c         |   51 +
>  drivers/net/qede/base/ecore_int.c         | 1131 +++
>  3 files changed, 14469 insertions(+)
>  create mode 100644 drivers/net/qede/base/ecore_attn_values.h
> 
I'm not familiar with the term "attentions" or "attention handling". 
Would "interrupt handling" or "async event handling" not be better to use in the
title and commit message to make things more unstandable to readers.

If you do want to use the term attentions in the commit message body, please
explain the term first. [I don't believe the term should be used in the commit
title, though]

Regards,
/Bruce