All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: robert.foss@collabora.com
Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org,
	marius.vlad@intel.com
Subject: Re: [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors.
Date: Tue, 26 Apr 2016 16:11:02 +0200	[thread overview]
Message-ID: <20160426141102.GO8291@phenom.ffwll.local> (raw)
In-Reply-To: <1461360300-20668-8-git-send-email-robert.foss@collabora.com>

On Fri, Apr 22, 2016 at 05:25:00PM -0400, robert.foss@collabora.com wrote:
> From: Robert Foss <robert.foss@collabora.com>
> 
> Add support for DRM_MODE_CONNECTOR_LVDS and DRM_MODE_CONNECTOR_DSI
> connectors.
> 
> Signed-off-by: Robert Foss <robert.foss@collabora.com>
> ---
>  tests/kms_panel_fitting.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
> index 60a22b0..933776c 100644
> --- a/tests/kms_panel_fitting.c
> +++ b/tests/kms_panel_fitting.c
> @@ -140,9 +140,15 @@ static void test_panel_fitting(data_t *d)
>  	for_each_connected_output(display, output) {
>  		drmModeModeInfo *mode, native_mode;
>  
> -		if (output->config.connector->connector_type !=
> -			DRM_MODE_CONNECTOR_eDP)
> -			continue;
> +		switch (output->config.connector->connector_type)
> +		{
> +		    case DRM_MODE_CONNECTOR_LVDS:
> +		    case DRM_MODE_CONNECTOR_eDP:
> +		    case DRM_MODE_CONNECTOR_DSI:
> +			    break;
> +		    default:
> +			    continue;
> +		}

I think ville commented that we should instead check for "scaling mode",
and we discussed this on irc. Am I accidentally looking at an old patch
series?
-Daniel

>  
>  		pipe = output->config.pipe;
>  		igt_output_set_pipe(output, pipe);
> -- 
> 2.5.0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2016-04-26 14:11 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-22 21:24 [PATCH i-g-t 0/7] Improve kms_panel_fitting robert.foss
2016-04-22 21:24 ` [PATCH i-g-t 1/7] kms_panel_fitting: Remove un-read variable robert.foss
2016-04-22 21:24 ` [PATCH i-g-t 2/7] kms_panel_fitting: Remove un-read variable pipe_crc robert.foss
2016-04-22 21:24 ` [PATCH i-g-t 3/7] kms_panel_fitting: Remove un-used variable robert.foss
2016-04-22 21:24 ` [PATCH i-g-t 4/7] kms_panel_fitting: Switched DRM format to a hardware agnostic alternative robert.foss
2016-04-22 21:24 ` [PATCH i-g-t 5/7] kms_panel_fitting: Enabled test on non-Intel hardware robert.foss
2016-04-22 21:24 ` [PATCH i-g-t 6/7] kms_panel_fitting: Don't skip test after finding an incompatible connector robert.foss
2016-04-26 14:10   ` Daniel Vetter
2016-04-26 16:50     ` Robert Foss
2016-04-28  8:01       ` Daniel Vetter
2016-04-22 21:25 ` [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors robert.foss
2016-04-22 22:31   ` Marius Vlad
2016-04-26 14:11   ` Daniel Vetter [this message]
2016-04-26 16:55     ` Robert Foss
2016-04-26 17:00       ` Ville Syrjälä
2016-04-26 17:08         ` Robert Foss
2016-04-28  8:02           ` Daniel Vetter
2016-04-28 14:07             ` Robert Foss
2016-04-28 14:41               ` Daniel Vetter
2016-04-28 15:57                 ` Robert Foss
2016-05-02  8:20                   ` Daniel Vetter
2016-05-02 19:16                     ` Robert Foss
2016-04-26 14:11 ` [PATCH i-g-t 0/7] Improve kms_panel_fitting Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160426141102.GO8291@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=marius.vlad@intel.com \
    --cc=robert.foss@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.