All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: bjorn.andersson@linaro.org
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, courtney.cavin@sonymobile.com,
	bjorn.andersson@sonymobile.com
Subject: Re: [PATCH v2] net: Add Qualcomm IPC router
Date: Wed, 27 Apr 2016 12:22:42 -0400 (EDT)	[thread overview]
Message-ID: <20160427.122242.1614940676503935894.davem@davemloft.net> (raw)
In-Reply-To: <1461736085-24862-1-git-send-email-bjorn.andersson@linaro.org>

From: Bjorn Andersson <bjorn.andersson@linaro.org>
Date: Tue, 26 Apr 2016 22:48:05 -0700

> +	rc = qcom_smd_send(qdev->channel, skb->data, skb->len);

I truly dislike adding networking protocols that depend upon some
piece of infrastructure that only some platforms can enable, it's even
worse when that set of platforms doesn't intersect with x86-64.

When you do things like this, it's quite hard to make protocol wide
changes to APIs because build testing becomes an issue.

This code can now only be build tested on ARCH_QCOM architectures, and
that's a serious negative downside.

  reply	other threads:[~2016-04-27 16:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-27  5:48 [PATCH v2] net: Add Qualcomm IPC router Bjorn Andersson
2016-04-27 16:22 ` David Miller [this message]
2016-04-27 17:14   ` Bjorn Andersson
2016-04-27 18:55     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160427.122242.1614940676503935894.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bjorn.andersson@linaro.org \
    --cc=bjorn.andersson@sonymobile.com \
    --cc=courtney.cavin@sonymobile.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.