From mboxrd@z Thu Jan  1 00:00:00 1970
From: Beniamino Galvani <b.galvani@gmail.com>
Date: Wed, 27 Apr 2016 12:58:32 +0200
Subject: [U-Boot] [PATCH v5 3/4] arm: add initial support for Amlogic
 Meson and ODROID-C2
In-Reply-To: <20160425205309.GB29322@bill-the-cat>
References: <1461480602-2932-1-git-send-email-b.galvani@gmail.com>
 <1461480602-2932-4-git-send-email-b.galvani@gmail.com>
 <20160425205309.GB29322@bill-the-cat>
Message-ID: <20160427105832.GA2586@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Mon, Apr 25, 2016 at 04:53:09PM -0400, Tom Rini wrote:
> > +#if !defined(CONFIG_IDENT_STRING)
> > +# define CONFIG_IDENT_STRING		" odroid-c2"
> > +#endif
> 
> Would this ever already be set?

No, it shouldn't.

> > +/* Serial setup */
> > +#define CONFIG_CONS_INDEX		0
> > +#define CONFIG_BAUDRATE			115200
> > +#define CONFIG_SYS_BAUDRATE_TABLE \
> > +	{ 4800, 9600, 19200, 38400, 57600, 115200 }
> 
> And I assume you could live with the default table really.

Right.

I will fix both and resubmit, thanks!

Beniamino