All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: felipe.balbi@linux.intel.com,
	Mathias Nyman <mathias.nyman@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Lee Jones <lee.jones@linaro.org>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface
Date: Wed, 27 Apr 2016 13:33:49 +0100	[thread overview]
Message-ID: <20160427123349.GL3217@sirena.org.uk> (raw)
In-Reply-To: <57201BC2.5040409@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 834 bytes --]

On Wed, Apr 27, 2016 at 09:54:10AM +0800, Lu Baolu wrote:

> Please refer to Documentation/acpi/gpio-properties.txt.

That's not visibly what your driver is doing, that is also recommending
using a static name which is what I'm asking for.

> > Why does the device care?It's requesting the GPIO in
> > its own context and it's only requesting one GPIO, with DT we're just
> > always calling the GPIO "gpio" which works fine.

> This driver is not bound to an ACPI device node directly. It's a child
> of a mfd device, which is corresponding to a real ACPI device node.

If it's the child of a MFD it's got an ACPI device, the ACPI device is
the parent.  It should use the parent device or the parent should map
the GPIO through to the child as many other MFDs do, the whole concept
of a MFD is a Linux internal implementation detail.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2016-04-27 12:34 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-25  8:04 [PATCH v6 00/10] usb: add support for Intel dual role port mux Lu Baolu
2016-04-25  8:04 ` [PATCH v6 01/10] extcon: usb-gpio: add device binding for platform device Lu Baolu
2016-04-25 23:51   ` Chanwoo Choi
2016-04-26  0:42     ` Lu Baolu
2016-04-25  8:04 ` [PATCH v6 02/10] extcon: usb-gpio: add support for ACPI gpio interface Lu Baolu
2016-04-25 23:51   ` Chanwoo Choi
2016-04-26  0:43     ` Lu Baolu
2016-04-25  8:04 ` [PATCH v6 03/10] regulator: fixed: add device binding for platform device Lu Baolu
2016-04-25 16:40   ` Mark Brown
2016-04-26  2:12     ` Lu Baolu
2016-04-25  8:04 ` [PATCH v6 04/10] regulator: fixed: add support for ACPI interface Lu Baolu
2016-04-25 17:30   ` Mark Brown
2016-04-26  2:24     ` Lu Baolu
2016-04-26 10:23       ` Mark Brown
2016-04-27  1:54         ` Lu Baolu
2016-04-27 12:33           ` Mark Brown [this message]
2016-04-28  5:55             ` Lu Baolu
2016-04-28 17:15               ` Mark Brown
2016-04-29  0:31                 ` Lu Baolu
2016-04-25  8:04 ` [PATCH v6 05/10] usb: mux: add generic code for dual role port mux Lu Baolu
2016-04-25  8:04 ` [PATCH v6 06/10] usb: mux: add driver for Intel gpio controlled " Lu Baolu
2016-04-25  8:04 ` [PATCH v6 07/10] usb: mux: add driver for Intel drcfg " Lu Baolu
2016-04-25  8:04 ` [PATCH v6 08/10] mfd: intel_vuport: Add Intel virtual USB port MFD Driver Lu Baolu
2016-04-25  8:04 ` [PATCH v6 09/10] usb: pci-quirks: add Intel USB drcfg mux device Lu Baolu
2016-04-25  8:04 ` [PATCH v6 10/10] MAINTAINERS: add maintainer entry for Intel USB dual role mux drivers Lu Baolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160427123349.GL3217@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=baolu.lu@linux.intel.com \
    --cc=cw00.choi@samsung.com \
    --cc=felipe.balbi@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=myungjoo.ham@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.