From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 27 Apr 2016 20:57:37 -0400 Subject: [U-Boot] [PATCH] arm: socfpga: Add samtec VIN|ING board In-Reply-To: <57215012.8060509@denx.de> References: <1460550259-9468-1-git-send-email-marex@denx.de> <570EBFE8.1000307@opensource.altera.com> <57215012.8060509@denx.de> Message-ID: <20160428005737.GH19598@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Apr 28, 2016 at 01:49:38AM +0200, Marek Vasut wrote: > On 04/13/2016 11:53 PM, Dinh Nguyen wrote: > > On 04/13/2016 07:24 AM, Marek Vasut wrote: > >> Add support for board based on the popular Altera Cyclone V SoC. > >> This board has the following properties: > >> - 1 GiB of DRAM > >> - 1 Gigabit ethernet > >> - 1 USB gadget port > >> - 1 USB host port with an on-board hub > >> - 2 QSPI NORs connected to the Cadence QSPI core > >> - Multiple I2C EEPROMs and one I2C temperature sensor > >> > >> Signed-off-by: Marek Vasut > >> Cc: Dinh Nguyen > >> Cc: Chin Liang See > >> --- > > > > [snip] > > > >> --- /dev/null > >> +++ b/include/configs/socfpga_vining_fpga.h > >> @@ -0,0 +1,246 @@ > >> +/* > >> + * Copyright (C) 2015 Marek Vasut > >> + * > >> + * SPDX-License-Identifier: GPL-2.0+ > >> + */ > >> +#ifndef __CONFIG_SAMTEC_VINING_FPGA_H__ > >> +#define __CONFIG_SAMTEC_VINING_FPGA_H__ > >> + > >> +#include > >> + > >> +/* U-Boot Commands */ > >> +#define CONFIG_SYS_NO_FLASH > >> +#define CONFIG_DOS_PARTITION > >> +#define CONFIG_FAT_WRITE > >> +#define CONFIG_HW_WATCHDOG > >> + > >> +#define CONFIG_CMD_ASKENV > >> +#define CONFIG_CMD_BOOTZ > >> +#define CONFIG_CMD_CACHE > >> +#define CONFIG_CMD_DFU > >> +#define CONFIG_CMD_DHCP > >> +#define CONFIG_CMD_EEPROM > >> +#define CONFIG_CMD_EXT4 > >> +#define CONFIG_CMD_EXT4_WRITE > >> +#define CONFIG_CMD_FAT > >> +#define CONFIG_CMD_FS_GENERIC > >> +#define CONFIG_CMD_GREPENV > >> +#define CONFIG_CMD_LED > >> +#define CONFIG_CMD_MII > >> +#define CONFIG_CMD_MMC > >> +#define CONFIG_CMD_PING > >> +#define CONFIG_CMD_USB > >> +#define CONFIG_CMD_USB_MASS_STORAGE > >> + > > > > With my patch[1], you don't need all of those common configs, all you > > need is: > > > > #define CONFIG_CMD_DFU > > #define CONFIG_CMD_USB > > #define CONFIG_CMD_USB_MASS_STORAGE > > Well since there are changes in that, are you fine if I pick this board > as-is for next ? You, or anyone else, picking up "old" board ports to apply now need to either ask people to re-spin the series or run moveconfig yourself to make sure that everything (except CMD_NAND) in cmd/Kconfig is done in the defconfig and not the config.h file. For example, those last 3 Kconfig'd right now. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: