From: Chris Wilson <chris@chris-wilson.co.uk>
To: tom.orourke@intel.com
Cc: intel-gfx@lists.freedesktop.org,
radoslaw.szwichtenberg@intel.com, paulo.r.zanoni@intel.com,
Tom O'Rourke <Tom.O'Rourke@intel.com>
Subject: Re: [PATCH 08/21] drm/i915/slpc: Allocate/Release/Initialize SLPC shared data
Date: Thu, 28 Apr 2016 08:15:28 +0100 [thread overview]
Message-ID: <20160428071528.GG4546@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <1461805865-212590-9-git-send-email-tom.orourke@intel.com>
On Wed, Apr 27, 2016 at 06:10:52PM -0700, tom.orourke@intel.com wrote:
> void intel_slpc_init(struct drm_device *dev)
> {
> - return;
> + struct drm_i915_private *dev_priv = dev->dev_private;
So what you wanted was dev_priv not dev!
> + struct drm_i915_gem_object *obj;
> +
> + /* Allocate shared data structure */
> + obj = dev_priv->guc.slpc.shared_data_obj;
This function (init) should be called exactly once. Do you intend to
also be part of the the init_hw phase?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-28 7:15 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 1:10 [PATCH v4 00/21] Add support for GuC-based SLPC tom.orourke
2016-04-28 1:10 ` [PATCH 01/21] drm/i915/slpc: Expose guc functions for use with SLPC tom.orourke
2016-04-28 7:00 ` Chris Wilson
2016-04-28 1:10 ` [PATCH 02/21] drm/i915/slpc: Add has_slpc capability flag tom.orourke
2016-04-28 1:10 ` [PATCH 03/21] drm/i915/slpc: Add slpc_version_check tom.orourke
2016-04-28 6:46 ` Chris Wilson
2016-04-28 1:10 ` [PATCH 04/21] drm/i915/slpc: Add enable_slpc module parameter tom.orourke
2016-04-28 7:02 ` Chris Wilson
2016-04-28 1:10 ` [PATCH 05/21] drm/i915/slpc: Use intel_slpc_* functions if supported tom.orourke
2016-04-28 1:10 ` [PATCH 06/21] drm/i915/slpc: Enable SLPC in guc " tom.orourke
2016-04-28 1:10 ` [PATCH 07/21] drm/i915/slpc: If using SLPC, do not set frequency tom.orourke
2016-04-28 6:34 ` Chris Wilson
2016-04-28 1:10 ` [PATCH 08/21] drm/i915/slpc: Allocate/Release/Initialize SLPC shared data tom.orourke
2016-04-28 7:15 ` Chris Wilson [this message]
2016-04-28 1:10 ` [PATCH 09/21] drm/i915/slpc: Setup rps frequency values during SLPC init tom.orourke
2016-04-28 6:41 ` Chris Wilson
2016-04-28 1:10 ` [PATCH 10/21] drm/i915/slpc: Update current requested frequency tom.orourke
2016-04-28 6:25 ` Chris Wilson
2016-04-28 1:10 ` [PATCH 11/21] drm/i915/slpc: Send reset event tom.orourke
2016-04-28 1:10 ` [PATCH 12/21] drm/i915/slpc: Send shutdown event tom.orourke
2016-04-28 7:07 ` Chris Wilson
2016-04-28 1:10 ` [PATCH 13/21] drm/i915/slpc: Add Display mode event related data structures tom.orourke
2016-04-28 1:10 ` [PATCH 14/21] drm/i915/slpc: Notification of Display mode change tom.orourke
2016-04-28 1:10 ` [PATCH 15/21] drm/i915/slpc: Notification of Refresh Rate change tom.orourke
2016-04-28 8:38 ` Daniel Vetter
2016-04-28 8:41 ` Daniel Vetter
2016-04-29 9:09 ` Ville Syrjälä
2016-04-28 1:11 ` [PATCH 16/21] drm/i915/slpc: Add slpc_status enum values tom.orourke
2016-04-28 1:11 ` [PATCH 17/21] drm/i915/slpc: Add parameter unset/set/get functions tom.orourke
2016-04-28 1:11 ` [PATCH 18/21] drm/i915/slpc: Add slpc support for max/min freq tom.orourke
2016-04-28 1:11 ` [PATCH 19/21] drm/i915/slpc: Add enable/disable debugfs for slpc tom.orourke
2016-04-28 7:28 ` Chris Wilson
2016-04-28 1:11 ` [PATCH 20/21] drm/i915/slpc: Add i915_slpc_info to debugfs tom.orourke
2016-04-28 1:11 ` [PATCH 21/21] drm/i915/slpc: Fail intel_runtime_suspend if SLPC or RPS not active tom.orourke
2016-04-28 6:56 ` Chris Wilson
2016-04-28 7:57 ` Imre Deak
2016-04-28 8:00 ` Chris Wilson
2016-04-29 9:34 ` Imre Deak
2016-04-28 7:16 ` ✓ Fi.CI.BAT: success for Add support for GuC-based SLPC (rev4) Patchwork
2016-04-28 23:01 ` [PATCH v4 00/21] Add support for GuC-based SLPC O'Rourke, Tom
2016-04-29 8:47 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160428071528.GG4546@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=Tom.O'Rourke@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=radoslaw.szwichtenberg@intel.com \
--cc=tom.orourke@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.