All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: omer.dagan-CtGflUZwD1xBDgjK7y7TUQ@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] rdma\hfi1 - coding style issues cleanup
Date: Thu, 28 Apr 2016 14:29:20 +0300	[thread overview]
Message-ID: <20160428112920.GA21343@leon.nu> (raw)
In-Reply-To: <1461830300-2851-1-git-send-email-omer.dagan-CtGflUZwD1xBDgjK7y7TUQ@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 529 bytes --]

On Thu, Apr 28, 2016 at 10:58:20AM +0300, omer.dagan-CtGflUZwD1xBDgjK7y7TUQ@public.gmane.org wrote:
> From: Omer Dagan <omer.dagan-CtGflUZwD1xBDgjK7y7TUQ@public.gmane.org>

Please fix subject line from rdma\hfi1 to be RDMA/hfi1, add description
to subject and to the commit message itself which explains why unsigned
variable needs to be declared as unsigned int variable and much more
important - COMPILE patches before sending them.

> -			unsigned free = 0U;
> +			unsigned iny free = 0U;
                                 ^^^

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2016-04-28 11:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-28  7:58 [PATCH] rdma\hfi1 - coding style issues cleanup omer.dagan-CtGflUZwD1xBDgjK7y7TUQ
     [not found] ` <1461830300-2851-1-git-send-email-omer.dagan-CtGflUZwD1xBDgjK7y7TUQ@public.gmane.org>
2016-04-28 11:29   ` Leon Romanovsky [this message]
2016-04-28 12:41   ` Dennis Dalessandro
     [not found]     ` <20160428124127.GB9685-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2016-05-12 20:25       ` Doug Ledford
     [not found]         ` <f7fb16c7-7d5b-6b77-7879-1f16bdf76665-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-05-13 14:21           ` Dennis Dalessandro
2016-04-28  9:22 omer.dagan-CtGflUZwD1xBDgjK7y7TUQ
     [not found] ` <1461835354-3077-1-git-send-email-omer.dagan-CtGflUZwD1xBDgjK7y7TUQ@public.gmane.org>
2016-04-28 12:14   ` Dennis Dalessandro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160428112920.GA21343@leon.nu \
    --to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=omer.dagan-CtGflUZwD1xBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.