From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: Re: [PATCH v2 5/9] x86: Introduce lib/x86/asm/barrier.h Date: Thu, 28 Apr 2016 19:00:13 +0200 Message-ID: <20160428170013.mp6hbt7hhqwm2so5@hawk.localdomain> References: <533e152f9d355b42e7698f693795745ff52e0797.1461762419.git.agordeev@redhat.com> <20160427135251.hqvj6rb6gklqxo2k@hawk.localdomain> <20160427162656.GB14081@dhcp-27-118.brq.redhat.com> <20160428162317.GA32394@dhcp-27-118.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, Thomas Huth , Radim =?utf-8?B?S3LEjW3DocWZ?= To: Alexander Gordeev Return-path: Received: from mx1.redhat.com ([209.132.183.28]:60949 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752615AbcD1RAR (ORCPT ); Thu, 28 Apr 2016 13:00:17 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ED43F80F7B for ; Thu, 28 Apr 2016 17:00:16 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160428162317.GA32394@dhcp-27-118.brq.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Apr 28, 2016 at 06:23:18PM +0200, Alexander Gordeev wrote: > On Wed, Apr 27, 2016 at 06:26:56PM +0200, Alexander Gordeev wrote: > > On Wed, Apr 27, 2016 at 03:52:51PM +0200, Andrew Jones wrote: > > > On Wed, Apr 27, 2016 at 03:13:54PM +0200, Alexander Gordeev wrote= : > > > > Make x86 consistent with other architectures and put > > > > memory barrier defines to lib/x86/asm/barrier.h > > > >=20 > > > > Cc: Andrew Jones > > > > Cc: Thomas Huth > > > > Cc: Radim Kr=C4=8Dm=C3=A1=C5=99 > > > > Signed-off-by: Alexander Gordeev > > > > --- > > > > lib/x86/asm/barrier.h | 8 ++++++++ > > > > lib/x86/asm/io.h | 1 + > > > > lib/x86/smp.h | 4 ---- > > > > x86/kvmclock.c | 1 + > > > > 4 files changed, 10 insertions(+), 4 deletions(-) > > > > create mode 100644 lib/x86/asm/barrier.h > > >=20 > > > Reviewed-by: Andrew Jones > >=20 > > I forgot about your _ASM_X86 vs _ASMX86 nit. > > I will resend this (and others affected). >=20 > Actually, all x86 headers have _ASM_X86 prefix, except > lib/x86/asm/bitops.h. So either introduce _ASM_X86_BARRIER_H_ > and _ASM_X86_PAGE_H_ and change _ASMX86_BITOPS_H_ or fix them > all. Or just do not do anything about that? :) It doesn't matter to me. Definitely don't fix anything, just pick whichever you like for this one :) >=20 > > > >=20 > > > > diff --git a/lib/x86/asm/barrier.h b/lib/x86/asm/barrier.h > > > > new file mode 100644 > > > > index 0000000..0ca1c56 > > > > --- /dev/null > > > > +++ b/lib/x86/asm/barrier.h > > > > @@ -0,0 +1,8 @@ > > > > +#ifndef _ASM_X86_BARRIER_H_ > > > > +#define _ASM_X86_BARRIER_H_ >=20 > Or _ASMX86_BARRIER_H_? Whatever :) thanks, drew