From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Jiri Slaby <jslaby@suse.cz>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Grant Edwards <grant.b.edwards@gmail.com>
Subject: Re: [PATCH 0/8] Replace kernel-defined ASYNC_ bits
Date: Thu, 28 Apr 2016 13:36:43 -0700 [thread overview]
Message-ID: <20160428203643.GA13542@kroah.com> (raw)
In-Reply-To: <1460249607-8014-1-git-send-email-peter@hurleysoftware.com>
On Sat, Apr 09, 2016 at 05:53:19PM -0700, Peter Hurley wrote:
> As outlined in my January email ("RFC: out-of-tree tty driver breakage"),
> the tty/serial core uses 5 bits in the tty_port.flags field to manage
> state. They are:
>
> ASYNCB_INITIALIZED
> ASYNCB_SUSPENDED
> ASYNCB_NORMAL_ACTIVE
> ASYNCB_CTS_FLOW
> ASYNCB_CHECK_CD
>
> (NB: ASYNC_CLOSING was recently removed)
>
> However, updates to this field (tty_port.flags) can be and often are
> non-atomic. Additionally, the field is visible to/modifiable by userspace
> (the state bits above are not modifiable by userspace though).
>
> This series moves these state bits into a different tty_port field
> (iflags) and abstracts state tests and changes with trivial helpers.
>
> The last patch of the series purposefully breaks out-of-tree driver
> builds to ensure they update state test/change methods to the helpers
> instead.
>
> REQUIRES: "tty: Replace TTY_IO_ERROR bit tests with tty_io_error()"
> "tty: Replace TTY_THROTTLED bit tests with tty_throttled()"
Wonderful, thanks for doing this work.
greg k-h
next prev parent reply other threads:[~2016-04-28 20:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-10 0:53 [PATCH 0/8] Replace kernel-defined ASYNC_ bits Peter Hurley
2016-04-10 0:53 ` [PATCH 1/8] tty: Define ASYNC_ replacement bits Peter Hurley
2016-04-10 0:53 ` [PATCH 2/8] tty: Replace ASYNC_CTS_FLOW bit and update atomically Peter Hurley
2016-04-10 0:53 ` [PATCH 3/8] tty: Replace ASYNC_NORMAL_ACTIVE " Peter Hurley
2016-04-10 0:53 ` [PATCH 4/8] tty: Replace ASYNC_CHECK_CD " Peter Hurley
2016-04-10 0:53 ` [PATCH 5/8] tty: Replace ASYNC_SUSPENDED bit " Peter Hurley
2016-04-10 0:53 ` [PATCH 6/8] tty: Replace ASYNC_INITIALIZED " Peter Hurley
2016-04-29 10:34 ` Johan Hovold
2016-04-10 0:53 ` [PATCH 7/8] tty: mxser: Remove unused ASYNC_SHARE_IRQ flag Peter Hurley
2016-04-10 0:53 ` [PATCH 8/8] tty: core: Undefine ASYNC_* flags superceded by TTY_PORT* flags Peter Hurley
2016-04-28 20:36 ` Greg Kroah-Hartman [this message]
2016-04-28 20:44 ` [PATCH 0/8] Replace kernel-defined ASYNC_ bits Grant Edwards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160428203643.GA13542@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=grant.b.edwards@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.