From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avx1H-00080c-40 for qemu-devel@nongnu.org; Thu, 28 Apr 2016 21:14:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avx1G-0006xW-Ar for qemu-devel@nongnu.org; Thu, 28 Apr 2016 21:14:59 -0400 Date: Fri, 29 Apr 2016 09:14:56 +0800 From: Fam Zheng Message-ID: <20160429011456.GC1421@ad.usersys.redhat.com> References: <1461849406-29743-1-git-send-email-kwolf@redhat.com> <1461849406-29743-3-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461849406-29743-3-git-send-email-kwolf@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 02/17] block: Introduce bdrv_driver_pwritev() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-block@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, sw@weilnetz.de, qemu-devel@nongnu.org On Thu, 04/28 15:16, Kevin Wolf wrote: > This is a function that simply calls into the block driver for doing a > write, providing the byte granularity interface we want to eventually > have everywhere, and using whatever interface that driver supports. > > This one is a bit more interesting that the version for reads: It adds s/that/than/ Othewise looks good. Fam > support for .bdrv_co_writev_flags() everywhere, so that drivers > implementing this function can drop .bdrv_co_writev() now. > > Signed-off-by: Kevin Wolf > Reviewed-by: Eric Blake