All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, mreitz@redhat.com, stefanha@redhat.com,
	sw@weilnetz.de, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 00/17] block: Convert .bdrv_read/write to .bdrv_preadv/pwritev
Date: Fri, 29 Apr 2016 11:29:48 +0800	[thread overview]
Message-ID: <20160429032948.GH1421@ad.usersys.redhat.com> (raw)
In-Reply-To: <1461849406-29743-1-git-send-email-kwolf@redhat.com>

On Thu, 04/28 15:16, Kevin Wolf wrote:
> This series introduces a new BlockDriver interface, which will hopefully be the
> final one, or at least good enough for another few years: .bdrv_preadv/pwritev.
> It is based on coroutines, vectored, has flags and uses a byte granularity.
> This is now the preferred interface for new drivers.
> 
> All drivers still using the legacy interface .bdrv_read/write are converted to
> the new interface and the emulation code we had for the old interface is
> removed. Most of the drivers become zero-copy with these patches as they are
> vectored now; only vvfat continues to allocate a bounce buffer.
> 
> The less obscure formats (vmdk, vdi, vpc) also natively support byte-aligned
> requests now. The block layer is still enforcing a minimal alignment of 512, so
> this isn't actually used yet, but in a next step, we can lift this restriction
> for drivers that implement .bdrv_preadv/pwritev.

Code working on byte granularity is consistent and much nicer to read!

Though I'm not 100% sure about the compressed write change in VMDK, but there
is apparently nothing wrong, too. So:

Reviewed-by: Fam Zheng <famz@redhat.com>

  parent reply	other threads:[~2016-04-29  3:29 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-28 13:16 [Qemu-devel] [PATCH v2 00/17] block: Convert .bdrv_read/write to .bdrv_preadv/pwritev Kevin Wolf
2016-04-28 13:16 ` [Qemu-devel] [PATCH v2 01/17] block: Introduce bdrv_driver_preadv() Kevin Wolf
2016-04-28 13:16 ` [Qemu-devel] [PATCH v2 02/17] block: Introduce bdrv_driver_pwritev() Kevin Wolf
2016-04-29  1:14   ` Fam Zheng
2016-04-30 21:54   ` Eric Blake
2016-04-28 13:16 ` [Qemu-devel] [PATCH v2 03/17] block: Support AIO drivers in bdrv_driver_preadv/pwritev() Kevin Wolf
2016-04-29  1:22   ` Fam Zheng
2016-04-29  3:25     ` Fam Zheng
2016-04-28 13:16 ` [Qemu-devel] [PATCH v2 04/17] block: Rename bdrv_co_do_preadv/writev to bdrv_co_preadv/writev Kevin Wolf
2016-04-28 13:16 ` [Qemu-devel] [PATCH v2 05/17] block: Introduce .bdrv_co_preadv/pwritev BlockDriver function Kevin Wolf
2016-04-28 15:21   ` Eric Blake
2016-04-28 13:16 ` [Qemu-devel] [PATCH v2 06/17] bochs: Implement .bdrv_co_preadv() interface Kevin Wolf
2016-04-28 15:50   ` Eric Blake
2016-04-28 13:16 ` [Qemu-devel] [PATCH v2 07/17] cloop: " Kevin Wolf
2016-04-29  2:28   ` Eric Blake
2016-04-28 13:16 ` [Qemu-devel] [PATCH v2 08/17] dmg: " Kevin Wolf
2016-04-29  2:39   ` Eric Blake
2016-04-28 13:16 ` [Qemu-devel] [PATCH v2 09/17] vdi: " Kevin Wolf
2016-04-28 13:16 ` [Qemu-devel] [PATCH v2 10/17] vdi: Implement .bdrv_co_pwritev() interface Kevin Wolf
2016-04-28 13:16 ` [Qemu-devel] [PATCH v2 11/17] vmdk: Add vmdk_find_offset_in_cluster() Kevin Wolf
2016-04-28 13:16 ` [Qemu-devel] [PATCH v2 12/17] vmdk: Implement .bdrv_co_preadv() interface Kevin Wolf
2016-04-28 13:16 ` [Qemu-devel] [PATCH v2 13/17] vmdk: Implement .bdrv_co_pwritev() interface Kevin Wolf
2016-04-29  3:08   ` Fam Zheng
2016-04-29  7:41     ` Kevin Wolf
2016-04-29  8:49     ` Pavel Butsykin
2016-04-29  9:49       ` Kevin Wolf
2016-04-29 10:31         ` Pavel Butsykin
2016-04-28 13:16 ` [Qemu-devel] [PATCH v2 14/17] vpc: Implement .bdrv_co_preadv() interface Kevin Wolf
2016-04-29  3:14   ` Fam Zheng
2016-04-28 13:16 ` [Qemu-devel] [PATCH v2 15/17] vpc: Implement .bdrv_co_pwritev() interface Kevin Wolf
2016-04-28 13:16 ` [Qemu-devel] [PATCH v2 16/17] vvfat: Implement .bdrv_co_preadv/pwritev interfaces Kevin Wolf
2016-04-28 13:16 ` [Qemu-devel] [PATCH v2 17/17] block: Remove BlockDriver.bdrv_read/write Kevin Wolf
2016-04-29  3:29 ` Fam Zheng [this message]
2016-04-29  9:57 ` [Qemu-devel] [PATCH v2 00/17] block: Convert .bdrv_read/write to .bdrv_preadv/pwritev Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160429032948.GH1421@ad.usersys.redhat.com \
    --to=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.