From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752269AbcD2H3T (ORCPT ); Fri, 29 Apr 2016 03:29:19 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:33131 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750940AbcD2H3R (ORCPT ); Fri, 29 Apr 2016 03:29:17 -0400 Date: Fri, 29 Apr 2016 16:30:50 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH 1/2] zsmalloc: require GFP in zs_malloc() Message-ID: <20160429073050.GA1252@swordfish> References: <1461860230-849-1-git-send-email-sergey.senozhatsky@gmail.com> <1461860230-849-2-git-send-email-sergey.senozhatsky@gmail.com> <20160429054441.GB2431@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160429054441.GB2431@bbox> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (04/29/16 14:44), Minchan Kim wrote: [..] > > @@ -1945,8 +1944,6 @@ struct zs_pool *zs_create_pool(const char *name, gfp_t flags) > > So, we can remove flags parameter passing and comment about that. good point; gfp_t is now unneeded there. will resubmit 0001 later. > Other than that, > > Acked-by: Minchan Kim thanks. -ss