* Re: [PATCH v2 01/13] staging/android: remove redundant comments on sync_merge_data
[not found] <00d201d1a1eb$86be73f0$943b5bd0$@alibaba-inc.com>
@ 2016-04-29 7:53 ` Hillf Danton
2016-04-29 13:30 ` Gustavo Padovan
0 siblings, 1 reply; 4+ messages in thread
From: Hillf Danton @ 2016-04-29 7:53 UTC (permalink / raw)
To: 'Gustavo Padovan'; +Cc: linux-kernel
>
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>
> struct sync_merge_data already have documentation on top of the
> struct definition. No need to duplicate it.
>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/staging/android/uapi/sync.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/android/uapi/sync.h b/drivers/staging/android/uapi/sync.h
> index 7de5d6a..413303d 100644
> --- a/drivers/staging/android/uapi/sync.h
> +++ b/drivers/staging/android/uapi/sync.h
> @@ -23,9 +23,9 @@
> * @pad: padding for 64-bit alignment, should always be zero
> */
> struct sync_merge_data {
> - char name[32]; /* name of new fence */
> - __s32 fd2; /* fd of second fence */
> - __s32 fence; /* fd on newly created fence */
> + char name[32];
> + __s32 fd2;
> + __s32 fence;
> __u32 flags;
> __u32 pad;
> };
> @@ -33,8 +33,8 @@ struct sync_merge_data {
> /**
> * struct sync_fence_info - detailed fence information
> * @obj_name: name of parent sync_timeline
> - * @driver_name: name of driver implementing the parent
> - * @status: status of the fence 0:active 1:signaled <0:error
> +* @driver_name: name of driver implementing the parent
> +* @status: status of the fence 0:active 1:signaled <0:error
Would you please specify why this hunk is needed, with
fence info not mentioned in commit message?
> * @flags: fence_info flags
> * @timestamp_ns: timestamp of status change in nanoseconds
> */
> --
> 2.5.5
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 01/13] staging/android: remove redundant comments on sync_merge_data
2016-04-29 7:53 ` [PATCH v2 01/13] staging/android: remove redundant comments on sync_merge_data Hillf Danton
@ 2016-04-29 13:30 ` Gustavo Padovan
0 siblings, 0 replies; 4+ messages in thread
From: Gustavo Padovan @ 2016-04-29 13:30 UTC (permalink / raw)
To: Hillf Danton; +Cc: linux-kernel
Hi Hillf,
2016-04-29 Hillf Danton <hillf.zj@alibaba-inc.com>:
> >
> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> >
> > struct sync_merge_data already have documentation on top of the
> > struct definition. No need to duplicate it.
> >
> > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > ---
> > drivers/staging/android/uapi/sync.h | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/staging/android/uapi/sync.h b/drivers/staging/android/uapi/sync.h
> > index 7de5d6a..413303d 100644
> > --- a/drivers/staging/android/uapi/sync.h
> > +++ b/drivers/staging/android/uapi/sync.h
> > @@ -23,9 +23,9 @@
> > * @pad: padding for 64-bit alignment, should always be zero
> > */
> > struct sync_merge_data {
> > - char name[32]; /* name of new fence */
> > - __s32 fd2; /* fd of second fence */
> > - __s32 fence; /* fd on newly created fence */
> > + char name[32];
> > + __s32 fd2;
> > + __s32 fence;
> > __u32 flags;
> > __u32 pad;
> > };
> > @@ -33,8 +33,8 @@ struct sync_merge_data {
> > /**
> > * struct sync_fence_info - detailed fence information
> > * @obj_name: name of parent sync_timeline
> > - * @driver_name: name of driver implementing the parent
> > - * @status: status of the fence 0:active 1:signaled <0:error
> > +* @driver_name: name of driver implementing the parent
> > +* @status: status of the fence 0:active 1:signaled <0:error
>
> Would you please specify why this hunk is needed, with
> fence info not mentioned in commit message?
This shouldn't be here. Probably some leftover from a rebase that I
didn't notice. Thanks for pointing it out. I'll update this patch.
Gustavo
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 01/13] staging/android: remove redundant comments on sync_merge_data
2016-04-28 13:46 [PATCH v2 00/13] De-stage Sync File Framework Gustavo Padovan
@ 2016-04-28 13:46 ` Gustavo Padovan
0 siblings, 0 replies; 4+ messages in thread
From: Gustavo Padovan @ 2016-04-28 13:46 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-kernel, devel, dri-devel, Daniel Stone,
Arve Hjønnevåg, Riley Andrews, Daniel Vetter,
Rob Clark, Greg Hackmann, John Harrison, Maarten Lankhorst,
Sumit Semwal, Gustavo Padovan
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
struct sync_merge_data already have documentation on top of the
struct definition. No need to duplicate it.
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/staging/android/uapi/sync.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/android/uapi/sync.h b/drivers/staging/android/uapi/sync.h
index 7de5d6a..413303d 100644
--- a/drivers/staging/android/uapi/sync.h
+++ b/drivers/staging/android/uapi/sync.h
@@ -23,9 +23,9 @@
* @pad: padding for 64-bit alignment, should always be zero
*/
struct sync_merge_data {
- char name[32]; /* name of new fence */
- __s32 fd2; /* fd of second fence */
- __s32 fence; /* fd on newly created fence */
+ char name[32];
+ __s32 fd2;
+ __s32 fence;
__u32 flags;
__u32 pad;
};
@@ -33,8 +33,8 @@ struct sync_merge_data {
/**
* struct sync_fence_info - detailed fence information
* @obj_name: name of parent sync_timeline
- * @driver_name: name of driver implementing the parent
- * @status: status of the fence 0:active 1:signaled <0:error
+* @driver_name: name of driver implementing the parent
+* @status: status of the fence 0:active 1:signaled <0:error
* @flags: fence_info flags
* @timestamp_ns: timestamp of status change in nanoseconds
*/
--
2.5.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 01/13] staging/android: remove redundant comments on sync_merge_data
@ 2016-04-28 13:46 ` Gustavo Padovan
0 siblings, 0 replies; 4+ messages in thread
From: Gustavo Padovan @ 2016-04-28 13:46 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: devel, Daniel Stone, Daniel Vetter, Riley Andrews, dri-devel,
linux-kernel, Arve Hjønnevåg, Gustavo Padovan,
John Harrison
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
struct sync_merge_data already have documentation on top of the
struct definition. No need to duplicate it.
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/staging/android/uapi/sync.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/android/uapi/sync.h b/drivers/staging/android/uapi/sync.h
index 7de5d6a..413303d 100644
--- a/drivers/staging/android/uapi/sync.h
+++ b/drivers/staging/android/uapi/sync.h
@@ -23,9 +23,9 @@
* @pad: padding for 64-bit alignment, should always be zero
*/
struct sync_merge_data {
- char name[32]; /* name of new fence */
- __s32 fd2; /* fd of second fence */
- __s32 fence; /* fd on newly created fence */
+ char name[32];
+ __s32 fd2;
+ __s32 fence;
__u32 flags;
__u32 pad;
};
@@ -33,8 +33,8 @@ struct sync_merge_data {
/**
* struct sync_fence_info - detailed fence information
* @obj_name: name of parent sync_timeline
- * @driver_name: name of driver implementing the parent
- * @status: status of the fence 0:active 1:signaled <0:error
+* @driver_name: name of driver implementing the parent
+* @status: status of the fence 0:active 1:signaled <0:error
* @flags: fence_info flags
* @timestamp_ns: timestamp of status change in nanoseconds
*/
--
2.5.5
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-29 13:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <00d201d1a1eb$86be73f0$943b5bd0$@alibaba-inc.com>
2016-04-29 7:53 ` [PATCH v2 01/13] staging/android: remove redundant comments on sync_merge_data Hillf Danton
2016-04-29 13:30 ` Gustavo Padovan
2016-04-28 13:46 [PATCH v2 00/13] De-stage Sync File Framework Gustavo Padovan
2016-04-28 13:46 ` [PATCH v2 01/13] staging/android: remove redundant comments on sync_merge_data Gustavo Padovan
2016-04-28 13:46 ` Gustavo Padovan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.