From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753805AbcD2Peg (ORCPT ); Fri, 29 Apr 2016 11:34:36 -0400 Received: from muru.com ([72.249.23.125]:52717 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752928AbcD2Pef (ORCPT ); Fri, 29 Apr 2016 11:34:35 -0400 Date: Fri, 29 Apr 2016 08:34:30 -0700 From: Tony Lindgren To: Peter Ujfalusi Cc: jarkko.nikula@bitmer.com, paul@pwsan.com, lgirdwood@gmail.com, broonie@kernel.org, t-kristo@ti.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v3 1/7] ARM: OMAP3: hwmod data: Fix McBSP2/3 sidetone data Message-ID: <20160429153430.GK5995@atomide.com> References: <1461927202-17677-1-git-send-email-peter.ujfalusi@ti.com> <1461927202-17677-2-git-send-email-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461927202-17677-2-git-send-email-peter.ujfalusi@ti.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Peter Ujfalusi [160429 03:55]: > The McBSPLP's sidetone main clock is the McBSPLP's ICLK, not FCLK as the > sidetone only receives the ICLK from the main McBSP module. > Since the McBSP and sidetone is using the very same clock from PRCM level > the sidetone must not have the prcm section to check the clock status since > the sidetone is only used when McBSP is already configured. > If two separate hwmods looking at the same bit and they would use > pm_runtime in nested way (as it must happen with McBSP and it's ST module) > the hwmod would warn, because the idlest will not match what it is expected > after enable/disable of the clocks. Thanks for looking into it, this looks right to me. Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v3 1/7] ARM: OMAP3: hwmod data: Fix McBSP2/3 sidetone data Date: Fri, 29 Apr 2016 08:34:30 -0700 Message-ID: <20160429153430.GK5995@atomide.com> References: <1461927202-17677-1-git-send-email-peter.ujfalusi@ti.com> <1461927202-17677-2-git-send-email-peter.ujfalusi@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1461927202-17677-2-git-send-email-peter.ujfalusi-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Ujfalusi Cc: jarkko.nikula-FVTvWyuFUl3QT0dZR+AlfA@public.gmane.org, paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, t-kristo-l0cyMroinI0@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org List-Id: devicetree@vger.kernel.org * Peter Ujfalusi [160429 03:55]: > The McBSPLP's sidetone main clock is the McBSPLP's ICLK, not FCLK as the > sidetone only receives the ICLK from the main McBSP module. > Since the McBSP and sidetone is using the very same clock from PRCM level > the sidetone must not have the prcm section to check the clock status since > the sidetone is only used when McBSP is already configured. > If two separate hwmods looking at the same bit and they would use > pm_runtime in nested way (as it must happen with McBSP and it's ST module) > the hwmod would warn, because the idlest will not match what it is expected > after enable/disable of the clocks. Thanks for looking into it, this looks right to me. Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Fri, 29 Apr 2016 08:34:30 -0700 Subject: [PATCH v3 1/7] ARM: OMAP3: hwmod data: Fix McBSP2/3 sidetone data In-Reply-To: <1461927202-17677-2-git-send-email-peter.ujfalusi@ti.com> References: <1461927202-17677-1-git-send-email-peter.ujfalusi@ti.com> <1461927202-17677-2-git-send-email-peter.ujfalusi@ti.com> Message-ID: <20160429153430.GK5995@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Peter Ujfalusi [160429 03:55]: > The McBSPLP's sidetone main clock is the McBSPLP's ICLK, not FCLK as the > sidetone only receives the ICLK from the main McBSP module. > Since the McBSP and sidetone is using the very same clock from PRCM level > the sidetone must not have the prcm section to check the clock status since > the sidetone is only used when McBSP is already configured. > If two separate hwmods looking at the same bit and they would use > pm_runtime in nested way (as it must happen with McBSP and it's ST module) > the hwmod would warn, because the idlest will not match what it is expected > after enable/disable of the clocks. Thanks for looking into it, this looks right to me. Tony