From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754086AbcEBPEZ (ORCPT ); Mon, 2 May 2016 11:04:25 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36284 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751623AbcEBPEQ (ORCPT ); Mon, 2 May 2016 11:04:16 -0400 Date: Mon, 2 May 2016 17:04:13 +0200 From: Daniel Vetter To: Rob Clark Cc: Gustavo Padovan , "dri-devel@lists.freedesktop.org" , Gustavo Padovan , David Airlie , Daniel Vetter , Ander Conselvan de Oliveira , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Carlos Palminha , Hai Li , Maarten Lankhorst , Archit Taneja , Daniel Stone , jilai wang , open list Subject: Re: [PATCH 05/14] drm/msm: use drm_crtc_send_vblank_event() Message-ID: <20160502150413.GS14148@phenom.ffwll.local> Mail-Followup-To: Rob Clark , Gustavo Padovan , "dri-devel@lists.freedesktop.org" , Gustavo Padovan , David Airlie , Ander Conselvan de Oliveira , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Carlos Palminha , Hai Li , Maarten Lankhorst , Archit Taneja , Daniel Stone , jilai wang , open list References: <1460656118-16766-1-git-send-email-gustavo@padovan.org> <1460656118-16766-5-git-send-email-gustavo@padovan.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 4.6.0-rc5+ User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 14, 2016 at 04:51:06PM -0400, Rob Clark wrote: > On Thu, Apr 14, 2016 at 1:48 PM, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Replace the legacy drm_send_vblank_event() with the new helper function. > > > > Signed-off-by: Gustavo Padovan > > thanks, shall I take this via msm-next for 4.7, I assume? Looks like > no dependency on drm-core patches that haven't already landed? > > Reviewed-by: Rob Clark Applied to drm-misc, thanks. -Daniel > > > --- > > drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c | 2 +- > > drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c > > index e233acf..3a48889 100644 > > --- a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c > > +++ b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c > > @@ -121,7 +121,7 @@ static void complete_flip(struct drm_crtc *crtc, struct drm_file *file) > > if (!file || (event->base.file_priv == file)) { > > mdp4_crtc->event = NULL; > > DBG("%s: send event: %p", mdp4_crtc->name, event); > > - drm_send_vblank_event(dev, mdp4_crtc->id, event); > > + drm_crtc_send_vblank_event(crtc, event); > > } > > } > > spin_unlock_irqrestore(&dev->event_lock, flags); > > diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c > > index 9673b95..ce779d9 100644 > > --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c > > +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c > > @@ -149,7 +149,7 @@ static void complete_flip(struct drm_crtc *crtc, struct drm_file *file) > > if (!file || (event->base.file_priv == file)) { > > mdp5_crtc->event = NULL; > > DBG("%s: send event: %p", mdp5_crtc->name, event); > > - drm_send_vblank_event(dev, mdp5_crtc->id, event); > > + drm_crtc_send_vblank_event(crtc, event); > > } > > } > > spin_unlock_irqrestore(&dev->event_lock, flags); > > -- > > 2.5.5 > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 05/14] drm/msm: use drm_crtc_send_vblank_event() Date: Mon, 2 May 2016 17:04:13 +0200 Message-ID: <20160502150413.GS14148@phenom.ffwll.local> References: <1460656118-16766-1-git-send-email-gustavo@padovan.org> <1460656118-16766-5-git-send-email-gustavo@padovan.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9C0EC88F07 for ; Mon, 2 May 2016 15:04:16 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id e201so17453806wme.2 for ; Mon, 02 May 2016 08:04:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Clark Cc: Daniel Stone , Carlos Palminha , "dri-devel@lists.freedesktop.org" , open list , Daniel Vetter , Gustavo Padovan List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBBcHIgMTQsIDIwMTYgYXQgMDQ6NTE6MDZQTSAtMDQwMCwgUm9iIENsYXJrIHdyb3Rl Ogo+IE9uIFRodSwgQXByIDE0LCAyMDE2IGF0IDE6NDggUE0sIEd1c3Rhdm8gUGFkb3ZhbiA8Z3Vz dGF2b0BwYWRvdmFuLm9yZz4gd3JvdGU6Cj4gPiBGcm9tOiBHdXN0YXZvIFBhZG92YW4gPGd1c3Rh dm8ucGFkb3ZhbkBjb2xsYWJvcmEuY28udWs+Cj4gPgo+ID4gUmVwbGFjZSB0aGUgbGVnYWN5IGRy bV9zZW5kX3ZibGFua19ldmVudCgpIHdpdGggdGhlIG5ldyBoZWxwZXIgZnVuY3Rpb24uCj4gPgo+ ID4gU2lnbmVkLW9mZi1ieTogR3VzdGF2byBQYWRvdmFuIDxndXN0YXZvLnBhZG92YW5AY29sbGFi b3JhLmNvLnVrPgo+IAo+IHRoYW5rcywgc2hhbGwgSSB0YWtlIHRoaXMgdmlhIG1zbS1uZXh0IGZv ciA0LjcsIEkgYXNzdW1lPyAgTG9va3MgbGlrZQo+IG5vIGRlcGVuZGVuY3kgb24gZHJtLWNvcmUg cGF0Y2hlcyB0aGF0IGhhdmVuJ3QgYWxyZWFkeSBsYW5kZWQ/Cj4gCj4gUmV2aWV3ZWQtYnk6IFJv YiBDbGFyayA8cm9iZGNsYXJrQGdtYWlsLmNvbT4KCkFwcGxpZWQgdG8gZHJtLW1pc2MsIHRoYW5r cy4KLURhbmllbAoKPiAKPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9tc20vbWRwL21kcDQv bWRwNF9jcnRjLmMgfCAyICstCj4gPiAgZHJpdmVycy9ncHUvZHJtL21zbS9tZHAvbWRwNS9tZHA1 X2NydGMuYyB8IDIgKy0KPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBk ZWxldGlvbnMoLSkKPiA+Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21zbS9tZHAv bWRwNC9tZHA0X2NydGMuYyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vbWRwL21kcDQvbWRwNF9jcnRj LmMKPiA+IGluZGV4IGUyMzNhY2YuLjNhNDg4ODkgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vbXNtL21kcC9tZHA0L21kcDRfY3J0Yy5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v bXNtL21kcC9tZHA0L21kcDRfY3J0Yy5jCj4gPiBAQCAtMTIxLDcgKzEyMSw3IEBAIHN0YXRpYyB2 b2lkIGNvbXBsZXRlX2ZsaXAoc3RydWN0IGRybV9jcnRjICpjcnRjLCBzdHJ1Y3QgZHJtX2ZpbGUg KmZpbGUpCj4gPiAgICAgICAgICAgICAgICAgaWYgKCFmaWxlIHx8IChldmVudC0+YmFzZS5maWxl X3ByaXYgPT0gZmlsZSkpIHsKPiA+ICAgICAgICAgICAgICAgICAgICAgICAgIG1kcDRfY3J0Yy0+ ZXZlbnQgPSBOVUxMOwo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgREJHKCIlczogc2VuZCBl dmVudDogJXAiLCBtZHA0X2NydGMtPm5hbWUsIGV2ZW50KTsKPiA+IC0gICAgICAgICAgICAgICAg ICAgICAgIGRybV9zZW5kX3ZibGFua19ldmVudChkZXYsIG1kcDRfY3J0Yy0+aWQsIGV2ZW50KTsK PiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGRybV9jcnRjX3NlbmRfdmJsYW5rX2V2ZW50KGNy dGMsIGV2ZW50KTsKPiA+ICAgICAgICAgICAgICAgICB9Cj4gPiAgICAgICAgIH0KPiA+ICAgICAg ICAgc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmZGV2LT5ldmVudF9sb2NrLCBmbGFncyk7Cj4gPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21zbS9tZHAvbWRwNS9tZHA1X2NydGMuYyBiL2Ry aXZlcnMvZ3B1L2RybS9tc20vbWRwL21kcDUvbWRwNV9jcnRjLmMKPiA+IGluZGV4IDk2NzNiOTUu LmNlNzc5ZDkgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL21kcC9tZHA1L21k cDVfY3J0Yy5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL21kcC9tZHA1L21kcDVfY3J0 Yy5jCj4gPiBAQCAtMTQ5LDcgKzE0OSw3IEBAIHN0YXRpYyB2b2lkIGNvbXBsZXRlX2ZsaXAoc3Ry dWN0IGRybV9jcnRjICpjcnRjLCBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUpCj4gPiAgICAgICAgICAg ICAgICAgaWYgKCFmaWxlIHx8IChldmVudC0+YmFzZS5maWxlX3ByaXYgPT0gZmlsZSkpIHsKPiA+ ICAgICAgICAgICAgICAgICAgICAgICAgIG1kcDVfY3J0Yy0+ZXZlbnQgPSBOVUxMOwo+ID4gICAg ICAgICAgICAgICAgICAgICAgICAgREJHKCIlczogc2VuZCBldmVudDogJXAiLCBtZHA1X2NydGMt Pm5hbWUsIGV2ZW50KTsKPiA+IC0gICAgICAgICAgICAgICAgICAgICAgIGRybV9zZW5kX3ZibGFu a19ldmVudChkZXYsIG1kcDVfY3J0Yy0+aWQsIGV2ZW50KTsKPiA+ICsgICAgICAgICAgICAgICAg ICAgICAgIGRybV9jcnRjX3NlbmRfdmJsYW5rX2V2ZW50KGNydGMsIGV2ZW50KTsKPiA+ICAgICAg ICAgICAgICAgICB9Cj4gPiAgICAgICAgIH0KPiA+ICAgICAgICAgc3Bpbl91bmxvY2tfaXJxcmVz dG9yZSgmZGV2LT5ldmVudF9sb2NrLCBmbGFncyk7Cj4gPiAtLQo+ID4gMi41LjUKPiA+CgotLSAK RGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDov L2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg==