From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754490AbcEBQDD (ORCPT ); Mon, 2 May 2016 12:03:03 -0400 Received: from mail-lf0-f52.google.com ([209.85.215.52]:35612 "EHLO mail-lf0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754334AbcEBQCy (ORCPT ); Mon, 2 May 2016 12:02:54 -0400 Date: Mon, 2 May 2016 19:02:50 +0300 From: "Kirill A. Shutemov" To: Dave Hansen Cc: Vlastimil Babka , "Odzioba, Lukasz" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "Shutemov, Kirill" , "Anaczkowski, Lukasz" Subject: Re: mm: pages are not freed from lru_add_pvecs after process termination Message-ID: <20160502160250.GD24419@node.shutemov.name> References: <5720F2A8.6070406@intel.com> <572766A7.9090406@suse.cz> <20160502150109.GB24419@node.shutemov.name> <572776EF.2070804@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <572776EF.2070804@intel.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 02, 2016 at 08:49:03AM -0700, Dave Hansen wrote: > On 05/02/2016 08:01 AM, Kirill A. Shutemov wrote: > > On Mon, May 02, 2016 at 04:39:35PM +0200, Vlastimil Babka wrote: > >> On 04/27/2016 07:11 PM, Dave Hansen wrote: > >>> 6. Perhaps don't use the LRU pagevecs for large pages. It limits the > >>> severity of the problem. > >> > >> I think that makes sense. Being large already amortizes the cost per base > >> page much more than pagevecs do (512 vs ~22 pages?). > > > > We try to do this already, don't we? Any spefic case where we have THPs on > > pagevecs? > > Lukas was hitting this on a RHEL 7 era kernel. In his kernel at least, > I'm pretty sure THP's were ending up on pagevecs. Are you saying you > don't think we're doing that any more? As Vlastimil pointed, we do. It need to be fixed, I think. Any volunteer? :-P -- Kirill A. Shutemov From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f70.google.com (mail-wm0-f70.google.com [74.125.82.70]) by kanga.kvack.org (Postfix) with ESMTP id 930886B0253 for ; Mon, 2 May 2016 12:02:53 -0400 (EDT) Received: by mail-wm0-f70.google.com with SMTP id e201so80392334wme.1 for ; Mon, 02 May 2016 09:02:53 -0700 (PDT) Received: from mail-lf0-x22e.google.com (mail-lf0-x22e.google.com. [2a00:1450:4010:c07::22e]) by mx.google.com with ESMTPS id y83si17432646lfc.84.2016.05.02.09.02.52 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 May 2016 09:02:52 -0700 (PDT) Received: by mail-lf0-x22e.google.com with SMTP id y84so192907073lfc.0 for ; Mon, 02 May 2016 09:02:52 -0700 (PDT) Date: Mon, 2 May 2016 19:02:50 +0300 From: "Kirill A. Shutemov" Subject: Re: mm: pages are not freed from lru_add_pvecs after process termination Message-ID: <20160502160250.GD24419@node.shutemov.name> References: <5720F2A8.6070406@intel.com> <572766A7.9090406@suse.cz> <20160502150109.GB24419@node.shutemov.name> <572776EF.2070804@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <572776EF.2070804@intel.com> Sender: owner-linux-mm@kvack.org List-ID: To: Dave Hansen Cc: Vlastimil Babka , "Odzioba, Lukasz" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "Shutemov, Kirill" , "Anaczkowski, Lukasz" On Mon, May 02, 2016 at 08:49:03AM -0700, Dave Hansen wrote: > On 05/02/2016 08:01 AM, Kirill A. Shutemov wrote: > > On Mon, May 02, 2016 at 04:39:35PM +0200, Vlastimil Babka wrote: > >> On 04/27/2016 07:11 PM, Dave Hansen wrote: > >>> 6. Perhaps don't use the LRU pagevecs for large pages. It limits the > >>> severity of the problem. > >> > >> I think that makes sense. Being large already amortizes the cost per base > >> page much more than pagevecs do (512 vs ~22 pages?). > > > > We try to do this already, don't we? Any spefic case where we have THPs on > > pagevecs? > > Lukas was hitting this on a RHEL 7 era kernel. In his kernel at least, > I'm pretty sure THP's were ending up on pagevecs. Are you saying you > don't think we're doing that any more? As Vlastimil pointed, we do. It need to be fixed, I think. Any volunteer? :-P -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org