All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] zram: user per-cpu compression streams
Date: Tue, 3 May 2016 10:40:18 +0900	[thread overview]
Message-ID: <20160503014018.GB2272@bbox> (raw)
In-Reply-To: <20160502092157.GA21764@swordfish>

On Mon, May 02, 2016 at 06:21:57PM +0900, Sergey Senozhatsky wrote:
> On (05/02/16 17:28), Minchan Kim wrote:
> [..]
> > > aha... I misunderstood you. I thought you talked about the test results
> > > in particular, not about zram stats in general. hm, given that we don't
> > > close the door for 'idle compression streams list' yet, and may revert
> > > per-cpu streams, may be we can introduce this stat in 4.8? otherwise, in
> > > the worst case, we will have to trim a user visible stat file once again
> > > IF we, for some reason, will decide to return idle list back (hopefully
> > > we will not). does it sound OK to you to not touch the stat file now?
> > 
> > My concern is how we can capture such regression without introducing
> > the stat of recompression? Do you have an idea? :)
> 
> ...hm...  inc ->failed_writes?
> 
> ... or as a dirty and ugly and illegal (read "undocumented") hack, we
> probably can use ->failed_reads for that purpose. simply because I don't
> think any one has ever seen ->failed_reads != 0.

:(

How about adding new debugfs for zram? And let's put unstable stats or
things we need to debug to there.

I got lessson from zs_create_pool discussion a few days ago,
"debugfs is just optioinal feature so it should be okay to not support
sometime e.g., -ENOMEM, -EEXIST and so on " although I'm not sure.

Logically, it might be right and easy to say but I don't believe it
makes sense practically. Once *userspace* relies on it, we should keep
the rule. No matter we said it thorugh document

I hope it's not only one person, fortunately one more people.

                https://lwn.net/Articles/309298/

Okay, let's add the knob to the existing sysfs(There is no different
between sysfs and debugfs with point of userspace once they start to
use it) because no need to add new code to avoid such mess.

Any thoughts?

  reply	other threads:[~2016-05-03  1:40 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-28 16:17 [PATCH 0/2] zram: switch to per-cpu compression streams Sergey Senozhatsky
2016-04-28 16:17 ` [PATCH 1/2] zsmalloc: require GFP in zs_malloc() Sergey Senozhatsky
2016-04-29  5:44   ` Minchan Kim
2016-04-29  7:30     ` Sergey Senozhatsky
2016-04-28 16:17 ` [PATCH 2/2] zram: user per-cpu compression streams Sergey Senozhatsky
2016-05-02  6:23   ` Minchan Kim
2016-05-02  7:25     ` Sergey Senozhatsky
2016-05-02  8:06       ` Sergey Senozhatsky
2016-05-03  5:23         ` Minchan Kim
2016-05-03  5:40           ` Minchan Kim
2016-05-03  5:57             ` Sergey Senozhatsky
2016-05-03  6:19               ` Minchan Kim
2016-05-03  7:01                 ` Sergey Senozhatsky
2016-05-03  5:44           ` Sergey Senozhatsky
2016-05-02  8:28       ` Minchan Kim
2016-05-02  9:21         ` Sergey Senozhatsky
2016-05-03  1:40           ` Minchan Kim [this message]
2016-05-03  1:53             ` Sergey Senozhatsky
2016-05-03  2:20               ` Minchan Kim
2016-05-03  2:30                 ` Sergey Senozhatsky
2016-05-03  4:29                   ` Sergey Senozhatsky
2016-05-03  5:03                     ` Minchan Kim
2016-05-03  6:53                       ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160503014018.GB2272@bbox \
    --to=minchan@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.