From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933730AbcECBwB (ORCPT ); Mon, 2 May 2016 21:52:01 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:35444 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932669AbcECBv7 (ORCPT ); Mon, 2 May 2016 21:51:59 -0400 Date: Tue, 3 May 2016 10:53:33 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Sergey Senozhatsky , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] zram: user per-cpu compression streams Message-ID: <20160503015333.GA9987@swordfish> References: <1461860230-849-1-git-send-email-sergey.senozhatsky@gmail.com> <1461860230-849-3-git-send-email-sergey.senozhatsky@gmail.com> <20160502062311.GB6077@bbox> <20160502072508.GA1811@swordfish> <20160502082822.GC6077@bbox> <20160502092157.GA21764@swordfish> <20160503014018.GB2272@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160503014018.GB2272@bbox> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Minchan, On (05/03/16 10:40), Minchan Kim wrote: > > > > ...hm... inc ->failed_writes? [..] > Okay, let's add the knob to the existing sysfs(There is no different > between sysfs and debugfs with point of userspace once they start to > use it) because no need to add new code to avoid such mess. > > Any thoughts? so you don't want to account failed fast-path writes in failed_writes? it sort of kind of fits, to some extent. re-compression is, basically, a new write operation -- allocate handle, map the page again, compress, etc., etc. so in a sense failed fast-path write is _almost_ a failed write, except that we took extra care of handling it and retried the op inside of zram, not from bio or fs layer. -ss