From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Valentin Subject: Re: [PATCH v3 3/4] thermal: of: enable temperature notifications Date: Mon, 2 May 2016 20:26:27 -0700 Message-ID: <20160503032626.GA18752@localhost.localdomain> References: <1459298497-29481-1-git-send-email-srikars@nvidia.com> <1459298497-29481-4-git-send-email-srikars@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1459298497-29481-4-git-send-email-srikars-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Srikar Srimath Tirumala Cc: rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, srinivas.pandruvada-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mlongnecker-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On Tue, Mar 29, 2016 at 05:41:36PM -0700, Srikar Srimath Tirumala wrote: > * Add a state variable to track if trip point is triggered. > * Enable trip events only when the state of the tirp point changes. > * Implement the get\set callbacks for trip state. > > Change-Id: I1bd6a7b0e5e520d8ee678b83111d23cada7a580c > Signed-off-by: Srikar Srimath Tirumala > --- > drivers/thermal/of-thermal.c | 43 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > > diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c > index 49ac23d..f6d9d3d 100644 > --- a/drivers/thermal/of-thermal.c > +++ b/drivers/thermal/of-thermal.c > @@ -379,6 +379,43 @@ static int of_thermal_get_crit_temp(struct thermal_zone_device *tz, > return -EINVAL; > } > > +static bool of_thermal_enb_temp_notify(struct thermal_zone_device *tz, int trip) > +{ > + bool ret = true; > + struct __thermal_zone *data = tz->devdata; > + > + if (trip >= data->ntrips || trip < 0) > + ret = false; > + > + return ret; > +} > + > +static int of_thermal_get_trip_state(struct thermal_zone_device *tz, int trip, > + enum thermal_trip_state *state) > +{ > + struct __thermal_zone *data = tz->devdata; > + > + if (trip >= data->ntrips || trip < 0) > + return -EDOM; > + > + *state = data->trips[trip].state; For the sake of the current implementation, I believe tracking state is probably more of a thermal core duty. Not sure this has anything to do with OF thermal. Could you please clarify why you think this has to be here? > + > + return 0; > +} > + > +static int of_thermal_set_trip_state(struct thermal_zone_device *tz, int trip, > + enum thermal_trip_state state) > +{ > + struct __thermal_zone *data = tz->devdata; > + > + if (trip >= data->ntrips || trip < 0) > + return -EDOM; > + > + data->trips[trip].state = state; > + > + return 0; > +} > + > static struct thermal_zone_device_ops of_thermal_ops = { > .get_mode = of_thermal_get_mode, > .set_mode = of_thermal_set_mode, > @@ -392,6 +429,10 @@ static struct thermal_zone_device_ops of_thermal_ops = { > > .bind = of_thermal_bind, > .unbind = of_thermal_unbind, > + > + .get_trip_state = of_thermal_get_trip_state, > + .set_trip_state = of_thermal_set_trip_state, > + .enb_temp_notify = of_thermal_enb_temp_notify, > }; > > /*** sensor API ***/ > @@ -782,6 +823,8 @@ static int thermal_of_populate_trip(struct device_node *np, > return ret; > } > > + trip->state = THERMAL_TRIP_NOT_TRIPPED; > + > /* Required for cooling map matching */ > trip->np = np; > of_node_get(np); > -- > 2.1.4 >