From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757357AbcEDJH0 (ORCPT ); Wed, 4 May 2016 05:07:26 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:48210 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756907AbcEDJHY (ORCPT ); Wed, 4 May 2016 05:07:24 -0400 Date: Wed, 4 May 2016 10:07:02 +0100 From: Mark Brown To: Robert Jarzmik Cc: Daniel Mack , Haojian Zhuang , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com Message-ID: <20160504090702.GV6292@sirena.org.uk> References: <1462050939-27940-1-git-send-email-robert.jarzmik@free.fr> <1462050939-27940-2-git-send-email-robert.jarzmik@free.fr> <20160503115159.GP6292@sirena.org.uk> <87y47roski.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1J4USyVh4Jt5OGCL" Content-Disposition: inline In-Reply-To: <87y47roski.fsf@belgarion.home> X-Cookie: Use in well-ventilated area. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFC PATCH 1/7] ALSA: ac97: split out the generic ac97 registers X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --1J4USyVh4Jt5OGCL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 03, 2016 at 09:22:05PM +0200, Robert Jarzmik wrote: > Mark Brown writes: > > On Sat, Apr 30, 2016 at 11:15:33PM +0200, Robert Jarzmik wrote: > >> Split out from the ac97_codec.h the ac97 generic registers, which can be > >> used by a codec, typically a generic ac97 codec, and by the ac97 bus, to > >> scan an ac97 AC-Link. > > I don't entirely see the value in this one but equally it does no harm. > Oh that's to have the defines AC97_VENDOR_ID1 and AC97_VENDOR_ID2, but without > including ac97_codec.h in sound/ac97/bus.c. I see that, I just don't know why that helps. --1J4USyVh4Jt5OGCL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXKbu1AAoJECTWi3JdVIfQB9oIAIRMtDQUGLLuldOzon/AP3ey EN62XgpfoES9IOYTf/EIj7xuNv7R6QoDXyBFnQeGtrmtlfyToyYL17ih8x1YIn88 PW4m8yT83UN8pmf+YhGxJxwJc1vTt+bxAO0wXKfsawntOBpp48zO+Qr/swqh14Rd Pw6FuHT7a11fGdUE+dEeY9Uo7EPOtoMtoXspAwJtHYCa2DmlIgAIz7AvlTguIuFG cvA2wkbhhzRNC5v9t/97+P1y1o2BX8/br8BcEti6uxxL8ou4E2ACrLr9dI0N1x4D 8H177VffZal8pma7FylifVLqm4t6H2tCF1XmSANht01zej9WCW+uxSit5Yb98F4= =KB3K -----END PGP SIGNATURE----- --1J4USyVh4Jt5OGCL-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: broonie@kernel.org (Mark Brown) Date: Wed, 4 May 2016 10:07:02 +0100 Subject: [RFC PATCH 1/7] ALSA: ac97: split out the generic ac97 registers In-Reply-To: <87y47roski.fsf@belgarion.home> References: <1462050939-27940-1-git-send-email-robert.jarzmik@free.fr> <1462050939-27940-2-git-send-email-robert.jarzmik@free.fr> <20160503115159.GP6292@sirena.org.uk> <87y47roski.fsf@belgarion.home> Message-ID: <20160504090702.GV6292@sirena.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, May 03, 2016 at 09:22:05PM +0200, Robert Jarzmik wrote: > Mark Brown writes: > > On Sat, Apr 30, 2016 at 11:15:33PM +0200, Robert Jarzmik wrote: > >> Split out from the ac97_codec.h the ac97 generic registers, which can be > >> used by a codec, typically a generic ac97 codec, and by the ac97 bus, to > >> scan an ac97 AC-Link. > > I don't entirely see the value in this one but equally it does no harm. > Oh that's to have the defines AC97_VENDOR_ID1 and AC97_VENDOR_ID2, but without > including ac97_codec.h in sound/ac97/bus.c. I see that, I just don't know why that helps. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: not available URL: