From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH v2] tools/virtio/ringtest: fix run-on-all.sh to work without /dev/cpu Date: Wed, 4 May 2016 10:14:54 +0200 Message-ID: <20160504101454.2b62e974.cornelia.huck@de.ibm.com> References: <20160504084021.18cf98f0.cornelia.huck@de.ibm.com> <1462348793-6944-1-git-send-email-rppt@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "Michael S. Tsirkin" , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org To: Mike Rapoport Return-path: Received: from e06smtp07.uk.ibm.com ([195.75.94.103]:42375 "EHLO e06smtp07.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757586AbcEDIPA (ORCPT ); Wed, 4 May 2016 04:15:00 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 4 May 2016 09:14:59 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id EABB6219004D for ; Wed, 4 May 2016 09:14:32 +0100 (BST) Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u448EuiM44826866 for ; Wed, 4 May 2016 08:14:56 GMT Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u448EtAP031854 for ; Wed, 4 May 2016 02:14:56 -0600 In-Reply-To: <1462348793-6944-1-git-send-email-rppt@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, 4 May 2016 10:59:53 +0300 Mike Rapoport wrote: > /dev/cpu is only available on x86 with certain modules (e.g. msr) enabled. > Using lscpu to get processors count is more portable. > > Signed-off-by: Mike Rapoport > --- > v2: use lspcu instead of /proc/cpuinfo as per Cornelia's suggestion > > tools/virtio/ringtest/run-on-all.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/virtio/ringtest/run-on-all.sh b/tools/virtio/ringtest/run-on-all.sh > index 52b0f71..0177d50 100755 > --- a/tools/virtio/ringtest/run-on-all.sh > +++ b/tools/virtio/ringtest/run-on-all.sh > @@ -3,10 +3,10 @@ > #use last CPU for host. Why not the first? > #many devices tend to use cpu0 by default so > #it tends to be busier > -HOST_AFFINITY=$(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n|tail -1) > +HOST_AFFINITY=$(lscpu -p | tail -n 1 | cut -d',' -f1) Shorter: lscpu -p=cpu | tail -1 Should be good enough for a test tool :) > > #run command on all cpus > -for cpu in $(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n); > +for cpu in $(seq 0 $HOST_AFFINITY) > do > #Don't run guest and host on same CPU > #It actually works ok if using signalling