All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Mike Rapoport <rppt@linux.vnet.ibm.com>
Cc: virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v2] tools/virtio/ringtest: fix run-on-all.sh to work without /dev/cpu
Date: Wed, 4 May 2016 10:14:54 +0200	[thread overview]
Message-ID: <20160504101454.2b62e974.cornelia.huck__46470.4855498441$1462349734$gmane$org@de.ibm.com> (raw)
In-Reply-To: <1462348793-6944-1-git-send-email-rppt@linux.vnet.ibm.com>

On Wed,  4 May 2016 10:59:53 +0300
Mike Rapoport <rppt@linux.vnet.ibm.com> wrote:

> /dev/cpu is only available on x86 with certain modules (e.g. msr) enabled.
> Using lscpu to get processors count is more portable.
> 
> Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com>
> ---
> v2: use lspcu instead of /proc/cpuinfo as per Cornelia's suggestion
> 
>  tools/virtio/ringtest/run-on-all.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/virtio/ringtest/run-on-all.sh b/tools/virtio/ringtest/run-on-all.sh
> index 52b0f71..0177d50 100755
> --- a/tools/virtio/ringtest/run-on-all.sh
> +++ b/tools/virtio/ringtest/run-on-all.sh
> @@ -3,10 +3,10 @@
>  #use last CPU for host. Why not the first?
>  #many devices tend to use cpu0 by default so
>  #it tends to be busier
> -HOST_AFFINITY=$(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n|tail -1)
> +HOST_AFFINITY=$(lscpu -p | tail -n 1 | cut -d',' -f1)

Shorter:

lscpu -p=cpu | tail -1

Should be good enough for a test tool :)

> 
>  #run command on all cpus
> -for cpu in $(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n);
> +for cpu in $(seq 0 $HOST_AFFINITY)
>  do
>  	#Don't run guest and host on same CPU
>  	#It actually works ok if using signalling

  reply	other threads:[~2016-05-04  8:14 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-04  6:12 [PATCH] tools/virtio/ringtest: add usage example to README Mike Rapoport
2016-05-04  6:12 ` [PATCH] tools/virtio/ringtest: fix run-on-all.sh to work without /dev/cpu Mike Rapoport
2016-05-04  6:40   ` Cornelia Huck
2016-05-04  6:40   ` Cornelia Huck
2016-05-04  7:59     ` [PATCH v2] " Mike Rapoport
2016-05-04  7:59     ` Mike Rapoport
2016-05-04  8:14       ` Cornelia Huck [this message]
2016-05-04  8:14       ` Cornelia Huck
2016-05-04 10:15         ` [PATCH v3] " Mike Rapoport
2016-05-04 10:24           ` Cornelia Huck
2016-05-24 12:41           ` Mike Rapoport
2016-06-06  6:55             ` Mike Rapoport
2016-06-06  6:55             ` Mike Rapoport
     [not found]             ` <201606060656.u566rhsn006487@mx0a-001b2d01.pphosted.com>
2016-06-06 13:57               ` Michael S. Tsirkin
2016-06-06 13:57               ` Michael S. Tsirkin
2016-05-04  6:12 ` [PATCH] " Mike Rapoport
2016-05-24 12:41 ` [PATCH] tools/virtio/ringtest: add usage example to README Mike Rapoport
2016-06-06  6:56   ` Mike Rapoport
2016-06-06  6:56   ` Mike Rapoport

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20160504101454.2b62e974.cornelia.huck__46470.4855498441$1462349734$gmane$org@de.ibm.com' \
    --to=cornelia.huck@de.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=rppt@linux.vnet.ibm.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.