From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2 12/17] pci: add a helper for device name
Date: Wed, 4 May 2016 17:36:32 +0100
Message-ID: <20160504163632.GA10392@bricha3-MOBL3>
References: <1454076516-21591-1-git-send-email-david.marchand@6wind.com>
 <1461152657-19969-13-git-send-email-david.marchand@6wind.com>
 <20160504152517.GA10164@bricha3-MOBL3> <1790773.lrclFWmpAI@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: David Marchand <david.marchand@6wind.com>, dev@dpdk.org,
 viktorin@rehivetech.com
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 693C6568E
 for <dev@dpdk.org>; Wed,  4 May 2016 18:36:36 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1790773.lrclFWmpAI@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, May 04, 2016 at 06:26:18PM +0200, Thomas Monjalon wrote:
> 2016-05-04 16:25, Bruce Richardson:
> > On Wed, Apr 20, 2016 at 01:44:12PM +0200, David Marchand wrote:
> > > eal is a better place than crypto / ethdev for naming resources.
> > > Add a helper in eal and make use of it in crypto / ethdev.
> > > 
> > > Signed-off-by: David Marchand <david.marchand@6wind.com>
> > > ---
> > >  lib/librte_cryptodev/rte_cryptodev.c    | 27 ++++-----------------------
> > >  lib/librte_eal/common/include/rte_pci.h | 25 +++++++++++++++++++++++++
> > >  lib/librte_ether/rte_ethdev.c           | 24 ++++--------------------
> > >  3 files changed, 33 insertions(+), 43 deletions(-)
> > > 
> > FYI: I see a compile error after applying this patch. It's unrelated directly to
> > this patch as root cause seems to be rte_debug.h missing an include for
> > rte_branch_prediction.h
> 
> It's probably due to this recent commit:
> 	http://dpdk.org/browse/dpdk/diff/lib/librte_eal/common/include/rte_debug.h?id=50705e

Yes, patch is in the works here...