Re: [GIT PULL FOR TEST v2] Another round of build script tweaks

["Paul E. McKenney" <paulmck@linux.vnet.ibm.com>]

On Thu, May 05, 2016 at 08:35:45AM +0900, Akira Yokosawa wrote:
> On 2016/05/05 0:39, Akira Yokosawa wrote:
> > Hi, Paul.
> > 
> > Finally, I set up a GitHub account, and pushed v2 of the series
> > "Another round of build script tweaks".
> > 
> > Please pull this into your local test branch and take time to see if
> > it actually works as you would expect. I'm fairly certain there would
> > be some regression, especially in the final commit 92ae43c3a72a
> > ("Further improvement of build scripts").
> > I'm also concerned about the fix of sig-theft.dot.
> > 
> > Changes from v1.
> >     Reorganized the entire series so that minor changes would come
> >     first.
> > 
> > Note: While I set up the account, I noticed a typo in my git-config
> > setting of user.email.  My email address in the commit messages so
> > far was wrong. Sorry for the slip-up...

So akiysw@gmail.com is wrong and akiyks@gmail.com is correct, right?
Looks like it from the email archives.

And in general, this looks to be good cleanup work.  I do have some
questions and comments below.

> >                                                 Thanks, Akira
> > 
> > ---
> > The following changes since commit 3f8bb7d620edee44637be00ba738761a4fc0732e:
> > 
> >   .gitignore: Add planned empty targets (2016-05-03 17:49:50 -0700)
> > 
> > are available in the git repository at:
> > 
> >   https://github.com/akiyks/perfbook.git makefile-tweaks-v2
> > 
> > for you to fetch changes up to 92ae43c3a72a3bcd7fd99ac681209ceafc6d7e65:
> > 
> >   Further improvement of build scripts (2016-05-04 23:43:06 +0900)
> > 
> > ----------------------------------------------------------------
> > Akira Yokosawa (7):
> >       Add font installation check

Hmmm...  The numbering is a bit inconsistent.  And there are a lot of
build questions.  We should place the trouble-shooting questions (1-4)
to a FAQ-build.txt file.  Then have FAQ.txt file question #1's answer be
"See FAQ-build.txt".  And then renumber the remaining FAQ.txt questions.

Would you be willing to do this?

Also, please delete "have ever" from "If you have ever built" in the
first line of the answer.

> >       Add short name targets in Makefile

For this one, the answer should also mention "make hb" for the
perfbook-hb.pdf that is useful for making hard-bound printouts.

> >       sig-theft: Fix .dot source for dot - graphviz version 2.36.0

Looks good!

> >       Make default target of "make" overridable

This one should mention "hb" as well.

> >       Makefile: Reorder rules

Looks good!

> >       Makefile: Use wildcards

Hmmm...  I didn't know that you could do this.  Something about having
started using "make" more than 30 years ago, I guess.

For BIBSOURCES, please do "BIBSOURCES = bib/*.bib" on one line.  I do
not expect multiple bibliography directories.

The dot files should probably be processed in the same way -- I added
them at different times, and apparently didn't make the processing
consistent.  As long as you are fixing things, this would be good to
fix as well.

> >       Further improvement of build scripts

I don't understand the point of interchanging the 1c and 2c rules.

I don't understand why perfbook.pdf no longer depends on extraction.
Ah, I see, the dependency is still there, but via perfbook.bbl and
perfbook_aux.

Rather than create "perfbook_aux" and "extraction" files, wouldn't it be
more natural for perfbook.aux to depend on contrib.tex and origpub.tex,
and then have separate rules to generate each of these files?  Ditto
or perfbook-bh_aux, and perfbook-1c_aux.

I do see the point of the "embedfonts" file -- nothing really to depend
on otherwise, since the files are fixed up in place.  So I am OK with
that one.

							Thanx, Paul

> >  .gitignore            |   1 -
> >  FAQ.txt               |  23 ++++
> >  Makefile              | 336 ++++++++++++++++++-------------------------------
> >  count/sig-theft.dot   |  17 +--
> >  count/sig-theft.eps   | 338 +++++++++++++++++++++++---------------------------
> >  utilities/eps2pdf.sh  |  12 ++
> >  utilities/runlatex.sh |   9 ++
> >  7 files changed, 333 insertions(+), 403 deletions(-)
> > 
> 
> There was a regression in Makefile that prevents build after "make distclean".
> The fix is pushed.
> 
> --- 
> The following changes since commit 92ae43c3a72a3bcd7fd99ac681209ceafc6d7e65:
> 
>   Further improvement of build scripts (2016-05-04 23:43:06 +0900)
> 
> are available in the git repository at:
> 
>   https://github.com/akiyks/perfbook.git makefile-tweaks-v2
> 
> for you to fetch changes up to c496b1d5c45dec5401658449d049d2b4e70148c4:
> 
>   Fix regression in Makefile (2016-05-05 08:23:46 +0900)
> 
> ----------------------------------------------------------------
> Akira Yokosawa (1):
>       Fix regression in Makefile
> 
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)
>