All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Alexei Starovoitov <ast@kernel.org>
Subject: Re: [for-next][PATCH 2/2] tracing: Use temp buffer when filtering events
Date: Thu, 5 May 2016 08:40:41 -0700	[thread overview]
Message-ID: <20160505154038.GA73672@ast-mbp.thefacebook.com> (raw)
In-Reply-To: <20160505113543.33f9a94b@gandalf.local.home>

On Thu, May 05, 2016 at 11:35:43AM -0400, Steven Rostedt wrote:
> On Thu, 5 May 2016 11:32:51 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > Think about it, what's the difference if the interrupt came in just
> > before the trace or just after? It still came in the same location with
> > respect to the normal flow of the code. The only difference is, where
> > we recorded it.
> 
> Also, if we used a temp buffer for each one, the same thing would
> happen. The interrupt would be committed first before returning back to
> the interrupted event. Perf does the same thing, but all the time.

yeah. good point. there is no actual 'order' here.
The whole thing looks good to me. 
Acked-by: Alexei Starovoitov <ast@kernel.org>

  reply	other threads:[~2016-05-05 15:40 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-04 13:52 [for-next][PATCH 0/2] tracing: Use a temp buffer when filtering events Steven Rostedt
2016-05-04 13:52 ` [for-next][PATCH 1/2] tracing: Remove TRACE_EVENT_FL_USE_CALL_FILTER logic Steven Rostedt
2016-05-04 13:52 ` [for-next][PATCH 2/2] tracing: Use temp buffer when filtering events Steven Rostedt
2016-05-05 15:20   ` Alexei Starovoitov
2016-05-05 15:32     ` Steven Rostedt
2016-05-05 15:35       ` Steven Rostedt
2016-05-05 15:40         ` Alexei Starovoitov [this message]
2020-08-28  7:53   ` Wen Gong
2020-08-28  7:53     ` Wen Gong
2020-08-28  7:53     ` Wen Gong
2020-08-28 22:49     ` Steven Rostedt
2020-08-28 22:49       ` Steven Rostedt
2020-08-28 22:49       ` Steven Rostedt
2020-08-28 22:54       ` Steven Rostedt
2020-08-28 22:54         ` Steven Rostedt
2020-08-28 22:54         ` Steven Rostedt
2020-08-28 22:55         ` Steven Rostedt
2020-08-28 22:55           ` Steven Rostedt
2020-08-28 22:55           ` Steven Rostedt
2020-08-29 15:52           ` Wen Gong
2020-08-29 15:52             ` Wen Gong
2020-08-29 15:52             ` Wen Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160505154038.GA73672@ast-mbp.thefacebook.com \
    --to=alexei.starovoitov@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=ast@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.