All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Pau Monne <roger.pau@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Ross Lagerwall <ross.lagerwall@citrix.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 for-4.7 5/6] xen/xsplice: add ELFOSABI_FREEBSD as a supported OSABI for payloads
Date: Thu, 5 May 2016 18:35:53 +0200	[thread overview]
Message-ID: <20160505163553.zescspglko4enstf@mac> (raw)
In-Reply-To: <5729EC5202000078000E8777@prv-mh.provo.novell.com>

On Wed, May 04, 2016 at 04:34:26AM -0600, Jan Beulich wrote:
> >>> On 04.05.16 at 11:48, <roger.pau@citrix.com> wrote:
> > On Tue, May 03, 2016 at 08:17:15AM -0600, Jan Beulich wrote:
> >> >>> On 03.05.16 at 12:55, <roger.pau@citrix.com> wrote:
> >> > The calling convention used by the FreeBSD ELF OSABI is exactly the same as
> >> > the the one defined by System V, so payloads with a FreeBSD OSABI should be
> >> > accepted by the xsplice machinery.
> >> 
> >> Well, you realize that the ABI is more than just the calling convention?
> >> I.e. your patch basically says ELFOSABI_NONE == ELFOSABI_FREEBSD,
> >> in which case I wonder why the latter exists in the first place. Is there
> >> a proper document somewhere describing everything the latter implies,
> >> so that one can check whether for xSplice purposes such similar
> >> treatment is indeed okay? Until then I'm afraid I'm opposed to this going
> >> in.
> > 
> > The FreeBSD elf OSABI only has a meaning for userspace applications, it's 
> > used by FreeBSD in order to detect if an application is native or if it 
> > needs to be run in the linuxator (the Linux emulator, or any other emulator 
> > that is available and matches the ELF OSABI specified in the binary FWIW).
> > 
> > THe only difference from SYSV to FreeBSD OSABI is the sysentvec that's 
> > selected inside of the FreeBSD kernel (the ABI between the kernel and the 
> > user-space application), but of course this doesn't apply to kernel code, 
> > which is what Xen and the xsplice payloads are. Sadly this is not written 
> > anywhere.
> 
> Well, okay, in that case I agree the patch should be fine.

Would you like me to resend this with a more expanded commit message, or are 
you going to squash my explanation in the commit message?

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-05-05 16:36 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-03 10:55 [PATCH v2 for-4.7 0/6] xSplice fixes (+1) Roger Pau Monne
2016-05-03 10:55 ` [PATCH v2 for-4.7 1/6] libxl: add a define for equivalent ENODATA errno on FreeBSD Roger Pau Monne
2016-05-03 11:30   ` Wei Liu
2016-05-03 10:55 ` [PATCH v2 for-4.7 2/6] tools/xsplice: corrently use errno Roger Pau Monne
2016-05-03 11:30   ` Wei Liu
2016-05-03 10:55 ` [PATCH v2 for-4.7 3/6] tools/xsplice: fix mixing system errno values with Xen ones Roger Pau Monne
2016-05-03 11:30   ` Wei Liu
2016-05-03 13:27   ` Konrad Rzeszutek Wilk
2016-05-03 13:29     ` Wei Liu
2016-05-03 13:37       ` Konrad Rzeszutek Wilk
2016-05-04 15:26         ` Wei Liu
2016-05-04 15:57           ` Konrad Rzeszutek Wilk
2016-05-06  8:54         ` Roger Pau Monne
2016-05-03 10:55 ` [PATCH v2 for-4.7 4/6] xen/xsplice: check against ELFOSABI_NONE instead of ELFOSABI_SYSV Roger Pau Monne
2016-05-03 12:22   ` Andrew Cooper
2016-05-03 14:13   ` Jan Beulich
2016-05-04  7:50   ` Jan Beulich
2016-05-03 10:55 ` [PATCH v2 for-4.7 5/6] xen/xsplice: add ELFOSABI_FREEBSD as a supported OSABI for payloads Roger Pau Monne
2016-05-03 12:21   ` Andrew Cooper
2016-05-03 14:17   ` Jan Beulich
2016-05-04  9:48     ` Roger Pau Monne
2016-05-04 10:34       ` Jan Beulich
2016-05-05 16:35         ` Roger Pau Monne [this message]
2016-05-06  6:51           ` Jan Beulich
2016-05-06 12:48   ` Ross Lagerwall
2016-05-06 16:34     ` Konrad Rzeszutek Wilk
2016-05-03 10:55 ` [PATCH v2 for-4.7 6/6] libxl: fix usage of XEN_EOPNOTSUPP Roger Pau Monne
2016-05-03 11:31   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160505163553.zescspglko4enstf@mac \
    --to=roger.pau@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=ross.lagerwall@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.