From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayNLQ-0006Yq-0v for qemu-devel@nongnu.org; Thu, 05 May 2016 13:45:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ayNLE-0008W8-8Y for qemu-devel@nongnu.org; Thu, 05 May 2016 13:45:42 -0400 Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]:35505) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayNLC-0008Q6-U0 for qemu-devel@nongnu.org; Thu, 05 May 2016 13:45:36 -0400 Received: by mail-wm0-x232.google.com with SMTP id e201so29578823wme.0 for ; Thu, 05 May 2016 10:45:20 -0700 (PDT) Date: Thu, 5 May 2016 18:45:15 +0100 From: Stefan Hajnoczi Message-ID: <20160505174515.GD14181@stefanha-x1.localdomain> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="eqp4TxRxnD4KrmFZ" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] rbd:change error_setg() to error_setg_errno() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vikhyat Umrao Cc: qemu-devel@nongnu.org, jcody@redhat.com --eqp4TxRxnD4KrmFZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 02, 2016 at 09:55:17PM +0530, Vikhyat Umrao wrote: > From 1c63c246f47a1a65d8740d7ce3725fe3820c0a37 Mon Sep 17 00:00:00 2001 > From: Vikhyat Umrao > Date: Mon, 2 May 2016 21:47:31 +0530 > Subject: [PATCH] rbd:change error_setg() to error_setg_errno() >=20 > Ceph RBD block driver does not use error_setg_errno() where > it is possible to use. This patch replaces error_setg() > from error_setg_errno(). >=20 > Signed-off-by: Vikhyat Umrao > --- > block/rbd.c | 37 ++++++++++++++++++++++--------------- > 1 file changed, 22 insertions(+), 15 deletions(-) >=20 > diff --git a/block/rbd.c b/block/rbd.c > index 5bc5b32..c286b32 100644 > --- a/block/rbd.c > +++ b/block/rbd.c > @@ -290,7 +290,7 @@ static int qemu_rbd_set_conf(rados_t cluster, const > char *conf, > if (only_read_conf_file) { > ret =3D rados_conf_read_file(cluster, value); > if (ret < 0) { > - error_setg(errp, "error reading conf file %s", value= ); > + error_setg_errno(errp, -ret, "error reading conf file > %s", value); Please use scripts/checkpatch.pl to scan patches for coding style violations. This line exceeds the maximum line length. --eqp4TxRxnD4KrmFZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXK4arAAoJEJykq7OBq3PIl/cH/21lNoqkYFvpwjBS5ujX3aDP 66GA9bpivSYg7YtHHuDrlSfbJOkTxrWAyQCoxNqlHOWrS54UNqmHDvqHkxYxHd9M JCebIhsolRHCXQhzuUpssz6lJ0gjLcRCmZJ83fVytASFBT347jAO2x7meA5BUGQG KsuIYjbQ+xDQrkhDQzVJd5Hwl9AnfRIjvCgMqs1msmjKdgVXexqV848BjF/jI0tB uDoDFsAwda+uF1ye/1znJwSuaR8NPAtjD0EQ95SZZ3YYzauXYuruRcsz4y95Nl52 oTGVWckl/r4Fk2cbFOV+nqqRbjBtLguCPoRA7o8naTOdBv/GyYykn4iduEWJzrI= =bInB -----END PGP SIGNATURE----- --eqp4TxRxnD4KrmFZ--