From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932184AbcEFLrH (ORCPT ); Fri, 6 May 2016 07:47:07 -0400 Received: from mail.kernel.org ([198.145.29.136]:40573 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932083AbcEFLrF (ORCPT ); Fri, 6 May 2016 07:47:05 -0400 Date: Fri, 6 May 2016 08:47:00 -0300 From: Arnaldo Carvalho de Melo To: He Kuang Cc: peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, adrian.hunter@intel.com, sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org, dsahern@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/8] perf tools: Omit DWARF judgement when recording dwarf callchain Message-ID: <20160506114700.GT11069@kernel.org> References: <1462525154-125656-1-git-send-email-hekuang@huawei.com> <1462525154-125656-2-git-send-email-hekuang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462525154-125656-2-git-send-email-hekuang@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, May 06, 2016 at 08:59:07AM +0000, He Kuang escreveu: > There's no need for dwarf support when perf recording with callchain. Can you rewrite this? We do need to have support for dwarf when processing "dwarf style" callchains. - Arnaldo > Signed-off-by: He Kuang > --- > tools/perf/util/util.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c > index b7766c5..e5ebfd4 100644 > --- a/tools/perf/util/util.c > +++ b/tools/perf/util/util.c > @@ -471,7 +471,6 @@ int parse_callchain_record(const char *arg, struct callchain_param *param) > "needed for --call-graph fp\n"); > break; > > -#ifdef HAVE_DWARF_UNWIND_SUPPORT > /* Dwarf style */ > } else if (!strncmp(name, "dwarf", sizeof("dwarf"))) { > const unsigned long default_stack_dump_size = 8192; > @@ -487,7 +486,6 @@ int parse_callchain_record(const char *arg, struct callchain_param *param) > ret = get_stack_size(tok, &size); > param->dump_size = size; > } > -#endif /* HAVE_DWARF_UNWIND_SUPPORT */ > } else if (!strncmp(name, "lbr", sizeof("lbr"))) { > if (!strtok_r(NULL, ",", &saveptr)) { > param->record_mode = CALLCHAIN_LBR; > -- > 1.8.5.2