From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 6 May 2016 15:38:16 +0200 From: Boris Brezillon To: Jorge Ramirez-Ortiz Cc: computersforpeace@gmail.com, dwmw2@infradead.org, matthias.bgg@gmail.com, robh@kernel.org, linux-mtd@lists.infradead.org, xiaolei.li@mediatek.com, linux-mediatek@lists.infradead.org, erin.lo@mediatek.com, daniel.thompson@linaro.org, blogic@openwrt.org Subject: Re: [PATCH v4 1/2] mtd: mediatek: device tree docs for MTK Smart Device Gen1 NAND Message-ID: <20160506153816.7ca581ac@bbrezillon> In-Reply-To: <1461946642-1842-2-git-send-email-jorge.ramirez-ortiz@linaro.org> References: <1461946642-1842-1-git-send-email-jorge.ramirez-ortiz@linaro.org> <1461946642-1842-2-git-send-email-jorge.ramirez-ortiz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Jorge, On Fri, 29 Apr 2016 12:17:21 -0400 Jorge Ramirez-Ortiz wrote: > This patch adds documentation support for Smart Device Gen1 type of > NAND controllers. > > Signed-off-by: Jorge Ramirez-Ortiz > --- > Documentation/devicetree/bindings/mtd/mtk-nand.txt | 161 +++++++++++++++++++++ > 1 file changed, 161 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/mtk-nand.txt > > diff --git a/Documentation/devicetree/bindings/mtd/mtk-nand.txt b/Documentation/devicetree/bindings/mtd/mtk-nand.txt > new file mode 100644 > index 0000000..175767d > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/mtk-nand.txt [...] > + > +Children nodes properties: > +- reg: Chip Select Signal, default 0. > + Set as reg = <0>, <1> when need 2 CS. > +Optional: > +- nand-on-flash-bbt: Store BBT on NAND Flash. > +- nand-ecc-mode: the NAND ecc mode (check driver for supported modes) > +- nand-ecc-step-size: Number of data bytes covered by a single ECC step. > + The controller only supports 512 and 1024. > + For large page NANDs ther recommended value is 1024. > +- nand-ecc-strength: Number of bits to correct per ECC step. > + The valid values that the controller supports are: 4, 6, > + 8, 10, 12, 14, 16, 18, 20, 22, 24, 28, 32, 36, 40, 44, > + 48, 52, 56, 60. > + The strength should be calculated as follows: > + E = (S - F) * 8 / 14 > + S = O / (P / Q) > + E :nand-ecc-strength; > + S :spare size per sector; > + F : FDM size, should be in the range [1,8]. > + It is used to store free oob data. > + O : oob size; > + P : page size; > + Q :nand-ecc-step-size > + If the result does not match any one of the listed > + choices above, please select the smaller valid value from > + the list. > + (otherwise the driver will do the clamping at runtime). > +- vmch-supply: NAND power supply. Where is this supply name coming from? I most datasheets I see Vdd or Vcc, but nothing close to Vmch. -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v4 1/2] mtd: mediatek: device tree docs for MTK Smart Device Gen1 NAND Date: Fri, 6 May 2016 15:38:16 +0200 Message-ID: <20160506153816.7ca581ac@bbrezillon> References: <1461946642-1842-1-git-send-email-jorge.ramirez-ortiz@linaro.org> <1461946642-1842-2-git-send-email-jorge.ramirez-ortiz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1461946642-1842-2-git-send-email-jorge.ramirez-ortiz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Jorge Ramirez-Ortiz Cc: robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, erin.lo-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org List-Id: linux-mediatek@lists.infradead.org Hi Jorge, On Fri, 29 Apr 2016 12:17:21 -0400 Jorge Ramirez-Ortiz wrote: > This patch adds documentation support for Smart Device Gen1 type of > NAND controllers. > > Signed-off-by: Jorge Ramirez-Ortiz > --- > Documentation/devicetree/bindings/mtd/mtk-nand.txt | 161 +++++++++++++++++++++ > 1 file changed, 161 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/mtk-nand.txt > > diff --git a/Documentation/devicetree/bindings/mtd/mtk-nand.txt b/Documentation/devicetree/bindings/mtd/mtk-nand.txt > new file mode 100644 > index 0000000..175767d > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/mtk-nand.txt [...] > + > +Children nodes properties: > +- reg: Chip Select Signal, default 0. > + Set as reg = <0>, <1> when need 2 CS. > +Optional: > +- nand-on-flash-bbt: Store BBT on NAND Flash. > +- nand-ecc-mode: the NAND ecc mode (check driver for supported modes) > +- nand-ecc-step-size: Number of data bytes covered by a single ECC step. > + The controller only supports 512 and 1024. > + For large page NANDs ther recommended value is 1024. > +- nand-ecc-strength: Number of bits to correct per ECC step. > + The valid values that the controller supports are: 4, 6, > + 8, 10, 12, 14, 16, 18, 20, 22, 24, 28, 32, 36, 40, 44, > + 48, 52, 56, 60. > + The strength should be calculated as follows: > + E = (S - F) * 8 / 14 > + S = O / (P / Q) > + E :nand-ecc-strength; > + S :spare size per sector; > + F : FDM size, should be in the range [1,8]. > + It is used to store free oob data. > + O : oob size; > + P : page size; > + Q :nand-ecc-step-size > + If the result does not match any one of the listed > + choices above, please select the smaller valid value from > + the list. > + (otherwise the driver will do the clamping at runtime). > +- vmch-supply: NAND power supply. Where is this supply name coming from? I most datasheets I see Vdd or Vcc, but nothing close to Vmch. -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com