From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758587AbcEFRRs (ORCPT ); Fri, 6 May 2016 13:17:48 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:58740 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757219AbcEFRRr (ORCPT ); Fri, 6 May 2016 13:17:47 -0400 Date: Fri, 6 May 2016 18:17:04 +0100 From: Mark Brown To: Robert Jarzmik Cc: Daniel Mack , Haojian Zhuang , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com Message-ID: <20160506171704.GY6292@sirena.org.uk> References: <1462050939-27940-1-git-send-email-robert.jarzmik@free.fr> <1462050939-27940-2-git-send-email-robert.jarzmik@free.fr> <20160503115159.GP6292@sirena.org.uk> <87y47roski.fsf@belgarion.home> <20160504090702.GV6292@sirena.org.uk> <87pot0pbnf.fsf@belgarion.home> <20160505191728.GK6292@sirena.org.uk> <87h9ecp9tp.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nRkE97iIlkj7lnZ0" Content-Disposition: inline In-Reply-To: <87h9ecp9tp.fsf@belgarion.home> X-Cookie: Use in well-ventilated area. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFC PATCH 1/7] ALSA: ac97: split out the generic ac97 registers X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nRkE97iIlkj7lnZ0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 05, 2016 at 09:46:10PM +0200, Robert Jarzmik wrote: > Mark Brown writes: > > On Thu, May 05, 2016 at 09:06:44PM +0200, Robert Jarzmik wrote: > >> Mark Brown writes: > >> This transition will be easier if the new ac97 code is isolated as much as > >> possible from the former code while providing backward compatibility ... hence > >> this patch. > > It'd probably have been clearer to me if it were splitting out all the > > register definitions rather than just some of them. > Euh unless I'm missing something I have splitted out all the ac97 generic > registers AFAIK. The only remaining ones are chip specific which I didn't take > as they should be in codec specific code and not ac97 generic one. The changelog read like it was trying to split things used by the controller vs things used by CODEC drivers, I didn't get as far as checking all the registers TBH. --nRkE97iIlkj7lnZ0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXLNGPAAoJECTWi3JdVIfQxWgH/3sJ1J4JI3kBqku4OHfoc2jm uXlCYfzb/brOfmZFoP2x6eis4K5ut1xvMN5OecypKWLFpS4dZApd7Kt/Yg7M+Fk7 NAcotCFJ3MV/BJ2v3L6NzFBXGrZGtKD0KN/1I16Oda7O9CzbJyO8O7vhTi2+hOfL vVad8MksGIsBzPgqr3W6yuS42YvUsd+AqeRuHt1UZBcb1CRWbzFbGnmn53ec0awy FRyVW2DpygRKY3tIvAtVIF7KE1VnIeMCH7ZfMp1pYMWpECKJoiL2iuhtTAbQBwUr AfWR4s8vfuS4VDpbK+AdAiXzeLUjdl1jSU0UcNp6FE+kVSKzMFYWSBq2azTI23Q= =B8s+ -----END PGP SIGNATURE----- --nRkE97iIlkj7lnZ0-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: broonie@kernel.org (Mark Brown) Date: Fri, 6 May 2016 18:17:04 +0100 Subject: [RFC PATCH 1/7] ALSA: ac97: split out the generic ac97 registers In-Reply-To: <87h9ecp9tp.fsf@belgarion.home> References: <1462050939-27940-1-git-send-email-robert.jarzmik@free.fr> <1462050939-27940-2-git-send-email-robert.jarzmik@free.fr> <20160503115159.GP6292@sirena.org.uk> <87y47roski.fsf@belgarion.home> <20160504090702.GV6292@sirena.org.uk> <87pot0pbnf.fsf@belgarion.home> <20160505191728.GK6292@sirena.org.uk> <87h9ecp9tp.fsf@belgarion.home> Message-ID: <20160506171704.GY6292@sirena.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, May 05, 2016 at 09:46:10PM +0200, Robert Jarzmik wrote: > Mark Brown writes: > > On Thu, May 05, 2016 at 09:06:44PM +0200, Robert Jarzmik wrote: > >> Mark Brown writes: > >> This transition will be easier if the new ac97 code is isolated as much as > >> possible from the former code while providing backward compatibility ... hence > >> this patch. > > It'd probably have been clearer to me if it were splitting out all the > > register definitions rather than just some of them. > Euh unless I'm missing something I have splitted out all the ac97 generic > registers AFAIK. The only remaining ones are chip specific which I didn't take > as they should be in codec specific code and not ac97 generic one. The changelog read like it was trying to split things used by the controller vs things used by CODEC drivers, I didn't get as far as checking all the registers TBH. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: not available URL: