All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Thimo Braker <thibmorozier@gmail.com>
Cc: arve@android.com, riandrews@android.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Thimo Braker <thibmorozier@hmail.com>
Subject: Re: [PATCH] Staging: android: gio: fixes a variable type issue and tabbing issues
Date: Sat, 7 May 2016 19:15:17 +0200	[thread overview]
Message-ID: <20160507171517.GA20652@kroah.com> (raw)
In-Reply-To: <1462636597-15311-1-git-send-email-thibmorozier@gmail.com>

On Sat, May 07, 2016 at 10:56:37AM -0500, Thimo Braker wrote:
> Fixes issues with the coding style checks.

What issues?  Always be specific, and describe what you are doing.  Also
don't put more than one "thing" in a single patch (hint, "coding style
cleanups" are not one thing.)

> 
> Signed-off-by: Thimo Braker <thibmorozier@hmail.com>
> ---
>  drivers/staging/android/timed_gpio.c   | 36 +++++++++++++++++-----------------
>  drivers/staging/android/timed_gpio.h   |  8 ++++----
>  drivers/staging/android/timed_output.c | 16 +++++++--------

These files are not in linux-next, please always work from that, they
have been gone from my tree for months now :(

thanks,

greg k-h

  reply	other threads:[~2016-05-07 17:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-07 15:56 [PATCH] Staging: android: gio: fixes a variable type issue and tabbing issues Thimo Braker
2016-05-07 17:15 ` Greg KH [this message]
2016-05-07 18:05   ` Thimo Braker
2016-05-07 19:01     ` Greg KH
2016-05-07 20:24       ` Thimo Braker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160507171517.GA20652@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arve@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riandrews@android.com \
    --cc=thibmorozier@gmail.com \
    --cc=thibmorozier@hmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.