From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751033AbcEGTOe (ORCPT ); Sat, 7 May 2016 15:14:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58131 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750968AbcEGTOc (ORCPT ); Sat, 7 May 2016 15:14:32 -0400 Date: Sat, 7 May 2016 21:14:27 +0200 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, peterz@infradead.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 07/10] perf, tools, stat: Scale values by unit before metrics Message-ID: <20160507191427.GI19977@krava> References: <1462489447-31832-1-git-send-email-andi@firstfloor.org> <1462489447-31832-8-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462489447-31832-8-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 05, 2016 at 04:04:04PM -0700, Andi Kleen wrote: > From: Andi Kleen > > Scale values by unit before passing them to the metrics printing functions. > This is needed for TopDown, because it needs to scale the slots correctly > by pipeline width / SMTness. > > For existing metrics it shouldn't make any difference, as those generally > use events that don't have any units. > > Signed-off-by: Andi Kleen Acked-by: Jiri Olsa thanks, jirka > --- > tools/perf/util/stat.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c > index 4d9b481cf3b6..ffa1d0653861 100644 > --- a/tools/perf/util/stat.c > +++ b/tools/perf/util/stat.c > @@ -307,6 +307,7 @@ int perf_stat_process_counter(struct perf_stat_config *config, > struct perf_counts_values *aggr = &counter->counts->aggr; > struct perf_stat_evsel *ps = counter->priv; > u64 *count = counter->counts->aggr.values; > + u64 val; > int i, ret; > > aggr->val = aggr->ena = aggr->run = 0; > @@ -346,7 +347,8 @@ int perf_stat_process_counter(struct perf_stat_config *config, > /* > * Save the full runtime - to allow normalization during printout: > */ > - perf_stat__update_shadow_stats(counter, count, 0); > + val = counter->scale * *count; > + perf_stat__update_shadow_stats(counter, &val, 0); > > return 0; > } > -- > 2.5.5 >