From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly Date: Mon, 9 May 2016 08:18:32 +0100 Message-ID: <20160509071832.GA8324@dell> References: <1461353935-8078-1-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1461353935-8078-1-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: Alexandre Courbot , Samuel Ortiz , Shobhit Kumar , intel-gfx@lists.freedesktop.org, stable@vger.kernel.org, linux-gpio@vger.kernel.org, Thierry Reding , Linus Walleij List-Id: linux-gpio@vger.kernel.org T24gRnJpLCAyMiBBcHIgMjAxNiwgdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20gd3JvdGU6 Cgo+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+ Cj4gCj4gR1BJTyBsb29rdXAgdGFibGVzIGFyZSBzdXBwb3NlZCB0byBiZSB6ZXJvIHRlcm1pbmF0 ZWQuIExldCdzIGRvIHRoYXQKPiBhbmQgYXZvaWQgYWNjaWRlbnRhbGx5IHdhbGtpbmcgb2ZmIHRo ZSBlbmQuCj4gCj4gQ2M6IFNob2JoaXQgS3VtYXIgPHNob2JoaXQua3VtYXJAaW50ZWwuY29tPgo+ IENjOiBTYW11ZWwgT3J0aXogPHNhbWVvQGxpbnV4LmludGVsLmNvbT4KPiBDYzogTGludXMgV2Fs bGVpaiA8bGludXMud2FsbGVpakBsaW5hcm8ub3JnPgo+IENjOiBBbGV4YW5kcmUgQ291cmJvdCA8 Z251cm91QGdtYWlsLmNvbT4KPiBDYzogVGhpZXJyeSBSZWRpbmcgPHRoaWVycnkucmVkaW5nQGdt YWlsLmNvbT4KPiBDYzogTGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9yZz4KPiBDYzogc3Rh YmxlQHZnZXIua2VybmVsLm9yZwo+IEZpeGVzOiA2MWRkMmNhMmQ0NGUgKCJtZmQ6IGludGVsX3Nv Y19wbWljX2NvcmU6IEFkZCBsb29rdXAgdGFibGUgZm9yIFBhbmVsIENvbnRyb2wgYXMgR1BJTyBz aWduYWwiKQo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvbWZkL2ludGVsX3NvY19wbWljX2NvcmUu YyB8IDEgKwo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykKCkFwcGxpZWQgd2l0aCBM aW51cycgYW5kIERhbmllbCdzIEFjay4KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWZkL2ludGVs X3NvY19wbWljX2NvcmUuYyBiL2RyaXZlcnMvbWZkL2ludGVsX3NvY19wbWljX2NvcmUuYwo+IGlu ZGV4IGQ5ZTE1Y2Y3YzZjOC4uMTJkNmViYjRhZTVkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbWZk L2ludGVsX3NvY19wbWljX2NvcmUuYwo+ICsrKyBiL2RyaXZlcnMvbWZkL2ludGVsX3NvY19wbWlj X2NvcmUuYwo+IEBAIC0zNSw2ICszNSw3IEBAIHN0YXRpYyBzdHJ1Y3QgZ3Bpb2RfbG9va3VwX3Rh YmxlIHBhbmVsX2dwaW9fdGFibGUgPSB7Cj4gIAkudGFibGUgPSB7Cj4gIAkJLyogUGFuZWwgRU4v RElTQUJMRSAqLwo+ICAJCUdQSU9fTE9PS1VQKCJncGlvX2NyeXN0YWxjb3ZlIiwgOTQsICJwYW5l bCIsIEdQSU9fQUNUSVZFX0hJR0gpLAo+ICsJCXsgfSwKPiAgCX0sCj4gIH07Cj4gIAoKLS0gCkxl ZSBKb25lcwpMaW5hcm8gU1RNaWNyb2VsZWN0cm9uaWNzIExhbmRpbmcgVGVhbSBMZWFkCkxpbmFy by5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBUk0gU29DcwpGb2xsb3cgTGluYXJv OiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com ([74.125.82.44]:34968 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751628AbcEIHS1 (ORCPT ); Mon, 9 May 2016 03:18:27 -0400 Received: by mail-wm0-f44.google.com with SMTP id e201so124318693wme.0 for ; Mon, 09 May 2016 00:18:26 -0700 (PDT) Date: Mon, 9 May 2016 08:18:32 +0100 From: Lee Jones To: ville.syrjala@linux.intel.com Cc: linux-gpio@vger.kernel.org, intel-gfx@lists.freedesktop.org, Shobhit Kumar , Samuel Ortiz , Linus Walleij , Alexandre Courbot , Thierry Reding , stable@vger.kernel.org Subject: Re: [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly Message-ID: <20160509071832.GA8324@dell> References: <1461353935-8078-1-git-send-email-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1461353935-8078-1-git-send-email-ville.syrjala@linux.intel.com> Sender: stable-owner@vger.kernel.org List-ID: On Fri, 22 Apr 2016, ville.syrjala@linux.intel.com wrote: > From: Ville Syrjälä > > GPIO lookup tables are supposed to be zero terminated. Let's do that > and avoid accidentally walking off the end. > > Cc: Shobhit Kumar > Cc: Samuel Ortiz > Cc: Linus Walleij > Cc: Alexandre Courbot > Cc: Thierry Reding > Cc: Lee Jones > Cc: stable@vger.kernel.org > Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal") > Signed-off-by: Ville Syrjälä > --- > drivers/mfd/intel_soc_pmic_core.c | 1 + > 1 file changed, 1 insertion(+) Applied with Linus' and Daniel's Ack. > diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c > index d9e15cf7c6c8..12d6ebb4ae5d 100644 > --- a/drivers/mfd/intel_soc_pmic_core.c > +++ b/drivers/mfd/intel_soc_pmic_core.c > @@ -35,6 +35,7 @@ static struct gpiod_lookup_table panel_gpio_table = { > .table = { > /* Panel EN/DISABLE */ > GPIO_LOOKUP("gpio_crystalcove", 94, "panel", GPIO_ACTIVE_HIGH), > + { }, > }, > }; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog