From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH V2 01/22] net-next: mediatek: use mdiobus_free() in favour of kfree() Date: Mon, 9 May 2016 14:07:35 +0200 Message-ID: <20160509120735.GR7972@lunn.ch> References: <1462788254-40572-1-git-send-email-john@phrozen.org> <1462788254-40572-2-git-send-email-john@phrozen.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, nbd@nbd.name, netdev@vger.kernel.org, linux-mediatek@lists.infradead.org To: John Crispin Return-path: Received: from vps0.lunn.ch ([178.209.37.122]:59697 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751360AbcEIMHp (ORCPT ); Mon, 9 May 2016 08:07:45 -0400 Content-Disposition: inline In-Reply-To: <1462788254-40572-2-git-send-email-john@phrozen.org> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, May 09, 2016 at 12:03:53PM +0200, John Crispin wrote: > The driver currently uses kfree() to clear the mii_bus. This is not the > correct way to clear the memory and mdiobus_free() should be used instead. > This patch fixes the two instances where this happens in the driver. > > Reported-by: Andrew Lunn > Signed-off-by: John Crispin Thanks John Reviewed-by: Andrew Lunn Andrew