From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751270AbcEIO0X (ORCPT ); Mon, 9 May 2016 10:26:23 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:37654 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750913AbcEIO0V (ORCPT ); Mon, 9 May 2016 10:26:21 -0400 Date: Mon, 9 May 2016 15:26:30 +0100 From: Lee Jones To: Lu Baolu Cc: felipe.balbi@linux.intel.com, Mathias Nyman , Greg Kroah-Hartman , Heikki Krogerus , Liam Girdwood , Mark Brown , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 5/7] mfd: intel_vuport: Add Intel virtual USB port MFD Driver Message-ID: <20160509142630.GJ8324@dell> References: <1462426383-3949-1-git-send-email-baolu.lu@linux.intel.com> <1462426383-3949-6-git-send-email-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1462426383-3949-6-git-send-email-baolu.lu@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 05 May 2016, Lu Baolu wrote: > Some Intel platforms have an USB port mux controlled by GPIOs. > There's a single ACPI platform device that provides 1) USB ID > extcon device; 2) USB vbus regulator device; and 3) USB port > switch device. This MFD driver will split these 3 devices for > their respective drivers. > > [baolu: removed .owner per platform_no_drv_owner.cocci] > Suggested-by: David Cohen > Signed-off-by: Lu Baolu > Reviewed-by: Felipe Balbi > --- > drivers/mfd/Kconfig | 8 +++++ > drivers/mfd/Makefile | 1 + > drivers/mfd/intel-vuport.c | 89 ++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 98 insertions(+) > create mode 100644 drivers/mfd/intel-vuport.c Acked-by: Lee Jones > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index eea61e3..7e115ab 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -1578,5 +1578,13 @@ config MFD_VEXPRESS_SYSREG > System Registers are the platform configuration block > on the ARM Ltd. Versatile Express board. > > +config MFD_INTEL_VUPORT > + tristate "Intel virtual USB port controller" > + select MFD_CORE > + depends on X86 && ACPI > + help > + Say Y here to enable support for Intel's dual role port mux > + controlled by GPIOs. > + > endmenu > endif > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > index 5eaa6465d..65b0518 100644 > --- a/drivers/mfd/Makefile > +++ b/drivers/mfd/Makefile > @@ -203,3 +203,4 @@ intel-soc-pmic-objs := intel_soc_pmic_core.o intel_soc_pmic_crc.o > intel-soc-pmic-$(CONFIG_INTEL_PMC_IPC) += intel_soc_pmic_bxtwc.o > obj-$(CONFIG_INTEL_SOC_PMIC) += intel-soc-pmic.o > obj-$(CONFIG_MFD_MT6397) += mt6397-core.o > +obj-$(CONFIG_MFD_INTEL_VUPORT) += intel-vuport.o > diff --git a/drivers/mfd/intel-vuport.c b/drivers/mfd/intel-vuport.c > new file mode 100644 > index 0000000..fa84ed7 > --- /dev/null > +++ b/drivers/mfd/intel-vuport.c > @@ -0,0 +1,89 @@ > +/* > + * MFD driver for Intel virtual USB port > + * > + * Copyright(c) 2016 Intel Corporation. > + * Author: Lu Baolu > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > +#include > +#include > +#include > +#include > +#include > + > +/* ACPI GPIO Mappings */ > +static const struct acpi_gpio_params id_gpio = { 0, 0, false }; > +static const struct acpi_gpio_params vbus_gpio = { 1, 0, false }; > +static const struct acpi_gpio_params mux_gpio = { 2, 0, false }; > +static const struct acpi_gpio_mapping acpi_usb_gpios[] = { > + { "id-gpios", &id_gpio, 1 }, > + { "gpio-gpios", &vbus_gpio, 1 }, > + { "usb_mux-gpios", &mux_gpio, 1 }, > + { }, > +}; > + > +static struct property_entry reg_properties[] = { > + PROPERTY_ENTRY_STRING("supply-name", "regulator-usb-gpio"), > + { }, > +}; > + > +static const struct property_set reg_properties_pset = { > + .properties = reg_properties, > +}; > + > +static const struct mfd_cell intel_vuport_mfd_cells[] = { > + { .name = "extcon-usb-gpio", }, > + { > + .name = "reg-fixed-voltage", > + .pset = ®_properties_pset, > + }, > + { .name = "intel-mux-gpio", }, > +}; > + > +static int vuport_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + int ret; > + > + ret = acpi_dev_add_driver_gpios(ACPI_COMPANION(dev), acpi_usb_gpios); > + if (ret) > + return ret; > + > + return mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE, > + intel_vuport_mfd_cells, > + ARRAY_SIZE(intel_vuport_mfd_cells), NULL, 0, > + NULL); > +} > + > +static int vuport_remove(struct platform_device *pdev) > +{ > + mfd_remove_devices(&pdev->dev); > + acpi_dev_remove_driver_gpios(ACPI_COMPANION(&pdev->dev)); > + > + return 0; > +} > + > +static struct acpi_device_id vuport_acpi_match[] = { > + { "INT3496" }, > + { } > +}; > +MODULE_DEVICE_TABLE(acpi, vuport_acpi_match); > + > +static struct platform_driver vuport_driver = { > + .driver = { > + .name = "intel-vuport", > + .acpi_match_table = ACPI_PTR(vuport_acpi_match), > + }, > + .probe = vuport_probe, > + .remove = vuport_remove, > +}; > + > +module_platform_driver(vuport_driver); > + > +MODULE_AUTHOR("Lu Baolu "); > +MODULE_DESCRIPTION("Intel virtual USB port"); > +MODULE_LICENSE("GPL v2"); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog