From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751475AbcEIO1r (ORCPT ); Mon, 9 May 2016 10:27:47 -0400 Received: from mga03.intel.com ([134.134.136.65]:19014 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751080AbcEIO1q (ORCPT ); Mon, 9 May 2016 10:27:46 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,601,1455004800"; d="scan'208";a="971807751" Date: Mon, 9 May 2016 07:27:41 -0700 From: Andi Kleen To: Peter Zijlstra Cc: Andi Kleen , acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , x86@kernel.org Subject: Re: [PATCH 02/10] x86, perf: Support sysfs files depending on SMT status Message-ID: <20160509142741.GI11177@tassilo.jf.intel.com> References: <1462489447-31832-1-git-send-email-andi@firstfloor.org> <1462489447-31832-3-git-send-email-andi@firstfloor.org> <20160509094219.GO3448@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160509094219.GO3448@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 09, 2016 at 11:42:19AM +0200, Peter Zijlstra wrote: > On Thu, May 05, 2016 at 04:03:59PM -0700, Andi Kleen wrote: > > From: Andi Kleen > > > > Add a way to show different sysfs events attributes depending on > > HyperThreading is on or off. This is difficult to determine > > early at boot, so we just do it dynamically when the sysfs > > attribute is read. > > > > v2: > > Compute HT status only once in CPU online/offline hooks. > > v3: Use topology_max_smt_threads() > > Signed-off-by: Andi Kleen > > --- > > arch/x86/events/core.c | 24 ++++++++++++++++++++++++ > > arch/x86/events/perf_event.h | 14 ++++++++++++++ > > include/linux/perf_event.h | 7 +++++++ > > 3 files changed, 45 insertions(+) > > > > Should this not now live in /sys/devices/system/cpu/ ? Thomas? This would be incompatible to all previous perf tools. Also not clear why you would want to move such events, just because they depend on SMT. -Andi -- ak@linux.intel.com -- Speaking for myself only