From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] ARM: dts: Fix igepv5 audiopwon-gpio Date: Mon, 9 May 2016 12:44:32 -0700 Message-ID: <20160509194431.GK5995@atomide.com> References: <1462474581-13865-1-git-send-email-tony@atomide.com> <1b37fbdd-67f0-e9e3-d442-bdc0bd74397b@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1b37fbdd-67f0-e9e3-d442-bdc0bd74397b@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Peter Ujfalusi Cc: Enric Balletbo i Serra , =?utf-8?Q?Agust=C3=AD?= Fontquerni , linux-omap@vger.kernel.org, Eduard Gavin , linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org KiBQZXRlciBVamZhbHVzaSA8cGV0ZXIudWpmYWx1c2lAdGkuY29tPiBbMTYwNTA5IDAxOjM2XToK PiBPbiAwNS8wNS8xNiAyMTo1NiwgVG9ueSBMaW5kZ3JlbiB3cm90ZToKPiA+IFBsYXlpbmcgYXVk aW8gd29ya3Mgb24gb21hcDUtdWV2bSwgYnV0IHByb2R1Y2VzIGFuICJVbmhhbmRsZWQgZmF1bHQ6 Cj4gPiBpbXByZWNpc2UgZXh0ZXJuYWwgYWJvcnQgKDB4MTQwNikgYXQgMHgwMDAwMDAwMCIgZXJy b3Igb24gaWdlcHY1Lgo+ID4gCj4gPiBMb29rcyBsaWtlIHRoZSB0d2w2MDQwIGF1ZHB3cm9uIEdQ SU8gcGluIGlzIGRpZmZlcmVudCBmb3IgdGhlc2UKPiA+IGJvYXJkcy4gTGV0J3MgZml4IHRoZSBp c3N1ZSBieSBjb25maWd1cmluZyB0aGUgYXVkcHdyb24gaW4gdGhlCj4gPiBib2FyZCBzcGVjaWZp YyBkdHMgZmlsZS4KPiA+IAo+ID4gQ2M6IEFndXN0w60gRm9udHF1ZXJuaSA8YWZAaXNlZWJjbi5j b20+Cj4gPiBDYzogRWR1YXJkIEdhdmluIDxlZ2F2aW5AaXNlZWJjbi5jb20+Cj4gPiBDYzogRW5y aWMgQmFsbGV0Ym8gaSBTZXJyYSA8ZWJhbGxldGJvQGlzZWViY24uY29tPgo+ID4gQ2M6IFBldGVy IFVqZmFsdXNpIDxwZXRlci51amZhbHVzaUB0aS5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBUb255 IExpbmRncmVuIDx0b255QGF0b21pZGUuY29tPgo+ID4gLS0tCj4gPiAgYXJjaC9hcm0vYm9vdC9k dHMvb21hcDUtYm9hcmQtY29tbW9uLmR0c2kgfCAgMyArKy0KPiA+ICBhcmNoL2FybS9ib290L2R0 cy9vbWFwNS1pZ2VwMDA1MC5kdHMgICAgICB8IDEwICsrKysrKysrKysKPiA+ICBhcmNoL2FybS9i b290L2R0cy9vbWFwNS11ZXZtLmR0cyAgICAgICAgICB8IDEwICsrKysrKysrKysKPiA+ICAzIGZp bGVzIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiA+IAo+ID4gZGlm ZiAtLWdpdCBhL2FyY2gvYXJtL2Jvb3QvZHRzL29tYXA1LWJvYXJkLWNvbW1vbi5kdHNpIGIvYXJj aC9hcm0vYm9vdC9kdHMvb21hcDUtYm9hcmQtY29tbW9uLmR0c2kKPiA+IGluZGV4IDJlZWEyNmMu LjIzYjFkN2MgMTAwNjQ0Cj4gPiAtLS0gYS9hcmNoL2FybS9ib290L2R0cy9vbWFwNS1ib2FyZC1j b21tb24uZHRzaQo+ID4gKysrIGIvYXJjaC9hcm0vYm9vdC9kdHMvb21hcDUtYm9hcmQtY29tbW9u LmR0c2kKPiA+IEBAIC02NDIsNyArNjQyLDggQEAKPiA+ICAJCXBpbmN0cmwtMCA9IDwmdHdsNjA0 MF9waW5zPjsKPiA+ICAKPiA+ICAJCWludGVycnVwdHMgPSA8R0lDX1NQSSAxMTkgSVJRX1RZUEVf Tk9ORT47IC8qIElSUV9TWVNfMk4gY2FzY2FkZWQgdG8gZ2ljICovCj4gPiAtCQl0aSxhdWRwd3Jv bi1ncGlvID0gPCZncGlvNSAxMyBHUElPX0FDVElWRV9ISUdIPjsgIC8qIGdwaW8gbGluZSAxNDEg Ki8KPiA+ICsKPiA+ICsJCS8qIGF1ZHB3cm9uIGdwaW8gZGVmaW5lZCBpbiB0aGUgYm9hcmQgc3Bl Y2lmaWMgZHRzICovCj4gPiAgCj4gPiAgCQl2aW8tc3VwcGx5ID0gPCZzbXBzN19yZWc+Owo+ID4g IAkJdjJ2MS1zdXBwbHkgPSA8JnNtcHM5X3JlZz47Cj4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0v Ym9vdC9kdHMvb21hcDUtaWdlcDAwNTAuZHRzIGIvYXJjaC9hcm0vYm9vdC9kdHMvb21hcDUtaWdl cDAwNTAuZHRzCj4gPiBpbmRleCA3MmZmNmE0Li42NzNjZGZhIDEwMDY0NAo+ID4gLS0tIGEvYXJj aC9hcm0vYm9vdC9kdHMvb21hcDUtaWdlcDAwNTAuZHRzCj4gPiArKysgYi9hcmNoL2FybS9ib290 L2R0cy9vbWFwNS1pZ2VwMDA1MC5kdHMKPiA+IEBAIC01OCwzICs1OCwxMyBAQAo+ID4gIAkJPCZn cGlvNyAzIDA+OwkJLyogMTk1LCBTREEgKi8KPiA+ICB9Owo+ID4gIAo+ID4gKyZ0d2w2MDQwIHsK PiA+ICsJdGksYXVkcHdyb24tZ3BpbyA9IDwmZ3BpbzUgMTYgR1BJT19BQ1RJVkVfSElHSD47ICAv KiBncGlvIGxpbmUgMTQ0ICovCj4gCj4gQlRXOiBob3cgZG8geW91IGtub3cgdGhhdCBncGlvMTQ0 IGlzIHVzZWQgYXMgYXVkcHdyb24gR1BJTyBvbiBpZ2VwdjU/CgpGcm9tIGxvb2tpbmcgYXQgdGhl IElTRUUgZ2l0IHRyZWUuIEJ1dCBpdCB3b3VsZCBiZSBiZXN0IGZvciB0aGUgSVNFRSBndXlzCnRv IHJldmlldyB0aGUgcGF0Y2guCgo+ID4gK307Cj4gPiArCj4gPiArJnR3bDYwNDBfcGlucyB7Cj4g PiArCXBpbmN0cmwtc2luZ2xlLHBpbnMgPSA8Cj4gPiArCQlPTUFQNV9JT1BBRCgweDFjNCwgUElO X09VVFBVVCB8IE1VWF9NT0RFNikJLyogbWNzcGkxX3NvbWkuZ3BpbzVfMTQ0ICovCj4gPiArCQlP TUFQNV9JT1BBRCgweDFjYSwgUElOX09VVFBVVCB8IE1VWF9NT0RFNikJLyogcGVyc2xpbWJ1czJf Y2xvY2suZ3BpbzVfMTQ1ICovCj4gCj4gV2hhdCBkb2VzIHRoZSBncGlvMTQ1IGlzIHVzZWQgZm9y PwoKTm8gaWRlYSB3aXRob3V0IHNlZWluZyB0aGUgc2NoZW1hdGljcywgYWxzbyBmcm9tIElTRUUg Z2l0IHRyZWUgc28gc2hvdWxkCmJlIHJldmlld2VkLgoKUmVnYXJkcywKClRvbnkKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwg bWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Mon, 9 May 2016 12:44:32 -0700 Subject: [PATCH] ARM: dts: Fix igepv5 audiopwon-gpio In-Reply-To: <1b37fbdd-67f0-e9e3-d442-bdc0bd74397b@ti.com> References: <1462474581-13865-1-git-send-email-tony@atomide.com> <1b37fbdd-67f0-e9e3-d442-bdc0bd74397b@ti.com> Message-ID: <20160509194431.GK5995@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Peter Ujfalusi [160509 01:36]: > On 05/05/16 21:56, Tony Lindgren wrote: > > Playing audio works on omap5-uevm, but produces an "Unhandled fault: > > imprecise external abort (0x1406) at 0x00000000" error on igepv5. > > > > Looks like the twl6040 audpwron GPIO pin is different for these > > boards. Let's fix the issue by configuring the audpwron in the > > board specific dts file. > > > > Cc: Agust? Fontquerni > > Cc: Eduard Gavin > > Cc: Enric Balletbo i Serra > > Cc: Peter Ujfalusi > > Signed-off-by: Tony Lindgren > > --- > > arch/arm/boot/dts/omap5-board-common.dtsi | 3 ++- > > arch/arm/boot/dts/omap5-igep0050.dts | 10 ++++++++++ > > arch/arm/boot/dts/omap5-uevm.dts | 10 ++++++++++ > > 3 files changed, 22 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi > > index 2eea26c..23b1d7c 100644 > > --- a/arch/arm/boot/dts/omap5-board-common.dtsi > > +++ b/arch/arm/boot/dts/omap5-board-common.dtsi > > @@ -642,7 +642,8 @@ > > pinctrl-0 = <&twl6040_pins>; > > > > interrupts = ; /* IRQ_SYS_2N cascaded to gic */ > > - ti,audpwron-gpio = <&gpio5 13 GPIO_ACTIVE_HIGH>; /* gpio line 141 */ > > + > > + /* audpwron gpio defined in the board specific dts */ > > > > vio-supply = <&smps7_reg>; > > v2v1-supply = <&smps9_reg>; > > diff --git a/arch/arm/boot/dts/omap5-igep0050.dts b/arch/arm/boot/dts/omap5-igep0050.dts > > index 72ff6a4..673cdfa 100644 > > --- a/arch/arm/boot/dts/omap5-igep0050.dts > > +++ b/arch/arm/boot/dts/omap5-igep0050.dts > > @@ -58,3 +58,13 @@ > > <&gpio7 3 0>; /* 195, SDA */ > > }; > > > > +&twl6040 { > > + ti,audpwron-gpio = <&gpio5 16 GPIO_ACTIVE_HIGH>; /* gpio line 144 */ > > BTW: how do you know that gpio144 is used as audpwron GPIO on igepv5? >>From looking at the ISEE git tree. But it would be best for the ISEE guys to review the patch. > > +}; > > + > > +&twl6040_pins { > > + pinctrl-single,pins = < > > + OMAP5_IOPAD(0x1c4, PIN_OUTPUT | MUX_MODE6) /* mcspi1_somi.gpio5_144 */ > > + OMAP5_IOPAD(0x1ca, PIN_OUTPUT | MUX_MODE6) /* perslimbus2_clock.gpio5_145 */ > > What does the gpio145 is used for? No idea without seeing the schematics, also from ISEE git tree so should be reviewed. Regards, Tony