From: David Miller <davem@davemloft.net>
To: brakmo@fb.com
Cc: netdev@vger.kernel.org, kernel-team@fb.com, ncardwell@google.com,
eric.dumazet@gmail.com, ycheng@google.com
Subject: Re: [PATCH v3 net-next] tcp: replace cnt & rtt with struct in pkts_acked()
Date: Tue, 10 May 2016 23:49:55 -0400 (EDT) [thread overview]
Message-ID: <20160510.234955.1868414439108959364.davem@davemloft.net> (raw)
In-Reply-To: <20160510.234758.925276118117758879.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Tue, 10 May 2016 23:47:58 -0400 (EDT)
> From: Lawrence Brakmo <brakmo@fb.com>
> Date: Tue, 10 May 2016 13:11:09 -0700
>
>> Replace 2 arguments (cnt and rtt) in the congestion control modules'
>> pkts_acked() function with a struct. This will allow adding more
>> information without having to modify existing congestion control
>> modules (tcp_nv in particular needs bytes in flight when packet
>> was sent).
>>
>> As proposed by Neal Cardwell in his comments to the tcp_nv patch.
>>
>> Signed-off-by: Lawrence Brakmo <brakmo@fb.com>
>> Acked-by: Yuchung Cheng <ycheng@google.com>
>
> Applied, thanks.
Actually I had to revert, this breaks the build:
net/ipv4/tcp_illinois.c: In function ‘tcp_illinois_acked’:
net/ipv4/tcp_illinois.c:97:18: error: assignment of member ‘rtt_us’ in read-only object
sample->rtt_us = RTT_MAX;
You can't mark this argument const.
prev parent reply other threads:[~2016-05-11 3:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 20:11 [PATCH v3 net-next] tcp: replace cnt & rtt with struct in pkts_acked() Lawrence Brakmo
2016-05-11 3:47 ` David Miller
2016-05-11 3:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160510.234955.1868414439108959364.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brakmo@fb.com \
--cc=eric.dumazet@gmail.com \
--cc=kernel-team@fb.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.