From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752306AbcEJHko (ORCPT ); Tue, 10 May 2016 03:40:44 -0400 Received: from mail-pf0-f177.google.com ([209.85.192.177]:36273 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751556AbcEJHkk (ORCPT ); Tue, 10 May 2016 03:40:40 -0400 Date: Tue, 10 May 2016 15:40:28 +0800 From: Peng Fan To: Alex Williamson Cc: b.reynal@virtualopensystems.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vfio: platform: use vfio_iommu_group_get/put Message-ID: <20160510074025.GA1064@linux-7smt.suse> References: <1462788103-19906-1-git-send-email-van.freenix@gmail.com> <20160509093238.3901f0b7@t450s.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160509093238.3901f0b7@t450s.home> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alex, On Mon, May 09, 2016 at 09:32:38AM -0600, Alex Williamson wrote: >On Mon, 9 May 2016 18:01:43 +0800 >Peng Fan wrote: > >> Use vfio_iommu_group_get and vfio_iommu_group_put, but not >> iommu_group_get or iommu_group_put. > >I assume you're trying to duplicate the vfio_pci changes from commit >03a76b60f8ba to enable no-iommu mode. That would be really relevant >information for the commit log. This is not to support non-iommu for vfio platform. I just think vfio_iommu_group_get/put is vfio core API and should be used by vfio-pci and vfio-platform. Thanks, Peng. > >> >> Signed-off-by: Peng Fan >> Cc: Baptiste Reynal >> Cc: Alex Williamson >> --- >> drivers/vfio/platform/vfio_platform_common.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c >> index e65b142..582885e 100644 >> --- a/drivers/vfio/platform/vfio_platform_common.c >> +++ b/drivers/vfio/platform/vfio_platform_common.c >> @@ -561,7 +561,7 @@ int vfio_platform_probe_common(struct vfio_platform_device *vdev, >> >> vdev->device = dev; >> >> - group = iommu_group_get(dev); >> + group = vfio_iommu_group_get(dev); >> if (!group) { >> pr_err("VFIO: No IOMMU group for device %s\n", vdev->name); >> return -EINVAL; >> @@ -569,7 +569,7 @@ int vfio_platform_probe_common(struct vfio_platform_device *vdev, >> >> ret = vfio_add_group_dev(dev, &vfio_platform_ops, vdev); >> if (ret) { >> - iommu_group_put(group); >> + vfio_iommu_group_put(group); >> return ret; >> } >> >> @@ -589,7 +589,7 @@ struct vfio_platform_device *vfio_platform_remove_common(struct device *dev) >> >> if (vdev) { >> vfio_platform_put_reset(vdev); >> - iommu_group_put(dev->iommu_group); >> + vfio_iommu_group_put(dev->iommu_group, dev); >> } >> >> return vdev; >