From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752155AbcEJNpS (ORCPT ); Tue, 10 May 2016 09:45:18 -0400 Received: from mail.kernel.org ([198.145.29.136]:38190 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751286AbcEJNpQ (ORCPT ); Tue, 10 May 2016 09:45:16 -0400 Date: Tue, 10 May 2016 10:45:12 -0300 From: Arnaldo Carvalho de Melo To: He Kuang Cc: peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, adrian.hunter@intel.com, sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org, dsahern@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/9] perf tools: Omit DWARF judgement when recording dwarf callchain Message-ID: <20160510134512.GG13209@kernel.org> References: <1462866037-30382-1-git-send-email-hekuang@huawei.com> <1462866037-30382-2-git-send-email-hekuang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462866037-30382-2-git-send-email-hekuang@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, May 10, 2016 at 07:40:29AM +0000, He Kuang escreveu: > There is no need to check for DWARF unwinding support when using the > 'dwarf' callchain record method, as this will only ask the kernel to > collect stack dumps for later DWARF CFI processing, which can be done > in another machine, where the support for DWARF unwinding need to be > present. I had this one already applied, thanks. - Arnaldo > Signed-off-by: He Kuang > Acked-by: Jiri Olsa > --- > tools/perf/util/util.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c > index b7766c5..e5ebfd4 100644 > --- a/tools/perf/util/util.c > +++ b/tools/perf/util/util.c > @@ -471,7 +471,6 @@ int parse_callchain_record(const char *arg, struct callchain_param *param) > "needed for --call-graph fp\n"); > break; > > -#ifdef HAVE_DWARF_UNWIND_SUPPORT > /* Dwarf style */ > } else if (!strncmp(name, "dwarf", sizeof("dwarf"))) { > const unsigned long default_stack_dump_size = 8192; > @@ -487,7 +486,6 @@ int parse_callchain_record(const char *arg, struct callchain_param *param) > ret = get_stack_size(tok, &size); > param->dump_size = size; > } > -#endif /* HAVE_DWARF_UNWIND_SUPPORT */ > } else if (!strncmp(name, "lbr", sizeof("lbr"))) { > if (!strtok_r(NULL, ",", &saveptr)) { > param->record_mode = CALLCHAIN_LBR; > -- > 1.8.5.2