From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0EH7-0005K7-15 for qemu-devel@nongnu.org; Tue, 10 May 2016 16:29:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0EH2-0007P2-AJ for qemu-devel@nongnu.org; Tue, 10 May 2016 16:28:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60179) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0EH2-0007Oj-49 for qemu-devel@nongnu.org; Tue, 10 May 2016 16:28:56 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B374385541 for ; Tue, 10 May 2016 20:28:55 +0000 (UTC) Date: Tue, 10 May 2016 17:28:53 -0300 From: Eduardo Habkost Message-ID: <20160510202853.GF4457@thinpad.lan.raisama.net> References: <1462192431-146342-1-git-send-email-imammedo@redhat.com> <1462192431-146342-24-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462192431-146342-24-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [RFC 23/42] tests: pc-cpu-test: turn on cpu-hotplug explicily List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, mst@redhat.com, marcel@redhat.com, eblake@redhat.com, armbru@redhat.com, drjones@redhat.com On Mon, May 02, 2016 at 02:33:32PM +0200, Igor Mammedov wrote: > Machine types before 2.7 have legacy CPU hotplug > enabled by defaut to not regress existing setups > where it's always enabled. > > But since 2.7 CPU hotplug is disabled y default > and requires explicit enabling using 'cpu-hotplug' > parameter in '-machine' option. > So turn it on for cpu-hotplug testcase to allow > it test 2.7 and later machine types. > > Fixes following failure: > > /x86_64/cpu/pc-q35-2.7/add/1x3x2&maxcpus=12: ** > ERROR:tests/pc-cpu-test.c:44:test_pc_with_cpu_add: > assertion failed: (!qdict_haskey(response, "error")) Is this test error introduced by a patch in this series? If so, shouldn't this fix be squashed with the patch that disables CPU hotplug by default, so we get a bisectable tree? -- Eduardo