All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@savoirfairelinux.com,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next 1/2] net: dsa: mv88e6xxx: abstract VTU/STU data access
Date: Tue, 10 May 2016 23:29:42 +0200	[thread overview]
Message-ID: <20160510212942.GA24788@lunn.ch> (raw)
In-Reply-To: <1462909469-4827-1-git-send-email-vivien.didelot@savoirfairelinux.com>

On Tue, May 10, 2016 at 03:44:28PM -0400, Vivien Didelot wrote:
> Both VTU and STU operations use the same routine to access their
> (common) data registers, with a different offset.
> 
> Add VTU and STU specific read and write functions to the data registers
> to abstract the required offset.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>

Hi Vivien

Improves the readability.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Thanks
	Andrew

  parent reply	other threads:[~2016-05-10 21:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-10 19:44 [PATCH net-next 1/2] net: dsa: mv88e6xxx: abstract VTU/STU data access Vivien Didelot
2016-05-10 19:44 ` [PATCH net-next 2/2] net: dsa: mv88e6xxx: add STU capability Vivien Didelot
2016-05-10 21:31   ` Andrew Lunn
2016-05-11 23:34   ` David Miller
2016-05-10 21:29 ` Andrew Lunn [this message]
2016-05-11 23:34 ` [PATCH net-next 1/2] net: dsa: mv88e6xxx: abstract VTU/STU data access David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160510212942.GA24788@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=kernel@savoirfairelinux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.